b64591e02c64785d11ce2011dca904d2cefb35fa
[binutils-gdb.git] / binutils / ChangeLog
1 2023-11-10 Vsevolod Alekseyev <sevaa@sprynet.com>
2
3 PR 30880
4 * dwarf.c (read_and_display_attr_value): Fix loclist handling.
5 (display_loclists_list): Likewise.
6
7 2023-10-24 Tom de Vries <tdevries@suse.de>
8
9 * dwarf.c (display_gdb_index): Handle unknown name of main.
10
11 2023-10-10 Tom de Vries <tdevries@suse.de>
12
13 * dwarf.c (display_lang): New function, factored out of ...
14 (read_and_display_attr_value): ... here.
15 (display_gdb_index): Handle v9 .gdb_index.
16
17 2023-10-05 A. Wilcox <awilfox@adelielinux.org>w
18
19 PR 30916
20 * testsuite/binutils-all/addr2line.exp: Do not use PowerPC
21 specific options when working with a MUSL target.
22
23 2023-10-02 Vsevolod Alekseyev <sevaa@sprynet.com>
24
25 PR 29267
26 * dwarf.c (fetch_indexed_value): Delete.
27 (fetch_indexed_offset): Correct base address calculation.
28 (read_and_display_attr_value): Replace uses of fetch_indexed_value
29 with fetch_indexed_offset.
30
31 2023-09-28 Frederic Cambus <fred@statdns.com>
32
33 * readelf.c (get_segment_type): Handle PT_OPENBSD_NOBTCFI segment
34 type.
35
36 2023-09-26 Nick Clifton <nickc@redhat.com>
37
38 * testsuite/binutils-all/ar.exp: Remove assumption of the setting
39 of umask when creating test archive files.
40
41 2023-09-25 Vsevolod Alekseyev <sevaa@sprynet.com>
42
43 PR 30792
44 * dwarf.h (struct debug_info): Remove range_versions field.
45 * dwarf.c (fetch_indexed_offset): New function.
46 (read_and_display_attr_value): Use it for DW_FORM_rnglistx.
47 Remove code to initialise range_versions.
48 (skip_attribute): New function.
49 (read_bases): Read and reccord all range and address bases in a CU.
50 (process_debug_info): Call read_bases.
51 (display_debug_rnglists): Rename to display_debug_rnglists_unit_header
52 and only display the range list header information.
53 (display_debug_ranges): Adjust.
54
55 2023-09-05 Nick Clifton <nickc@redhat.com>
56
57 PR 30684
58 * readelf.c (extra_sym_info): New variable.
59 (section_name_valid): Also check for filedata being NULL.
60 (section_name_print): Delete.
61 (section_index_real): New function. Returns true if the given
62 section index references a real section.
63 (print_symbol): Rename to print_sumbol_name.
64 (printable_section_name): Use a rotating array of static buffers
65 for the return string.
66 (printable_section_name_from_index): Merge code from
67 dump_relocations and get_symbol_index_type into here.
68 (long_option_values): Add OPTION_NO_EXTRA_SYM_INFO.
69 (options): Add "extra-sym-info" and "no-extra-sym-info".
70 (usage): Mention new options.
71 (parse_args): Parse new options.
72 (get_symbol_index_type): Delete.
73 (print_dynamic_symbol_size): Rename to print_symbol_size.
74 (print_dynamic_symbol): Rename to print_symbol.
75 (print_symbol_table_heading): New function.
76 (process_symbol_table): Use new function.
77 * doc/binutils.texi: Document the new option.
78 * NEWS: Mention the new feature.
79
80 2023-08-23 Nick Clifton <nickc@redhat.com>
81
82 PR 30781
83 * dwarf.h (debug_info): Add range_versions field.
84 * dwarf.c (read_and_display_attr_value): When recording a range
85 arribute also ecord the dwarf version number.
86 (is_range_list_for_this_section): New function.
87 (display_debug_ranges): Only show debug ranges whose version is
88 suitable for the secction being displayed.
89
90 2023-07-30 Jose E. Marchesi <jose.marchesi@oracle.com>
91
92 * readelf.c (get_machine_flags): Recognize and pretty print BPF
93 machine flags.
94
95 2023-07-24 Johannes Schauer Marin Rodrigues <josch@debian.org>
96
97 * doc/binutils.texi (objcopy): Document change in behaviour of
98 objcopy's --preserve-dates command line option.
99
100 2023-07-09 Fangrui Song <maskray@google.com>
101
102 PR 30592
103 * NEWS: Mention the new feature for objcopy.
104 * doc/binutils.texi: Mention "large".
105 * objcopy.c (parse_flags): Parse "large".
106 (check_new_section_flags): Error if "large" is used with a
107 non-x86-64 ELF target.
108 * testsuite/binutils-all/x86-64/large-sections.d: New.
109 * testsuite/binutils-all/x86-64/large-sections.s: New.
110 * testsuite/binutils-all/x86-64/large-sections-i386.d: New.
111 * testsuite/binutils-all/x86-64/large-sections-2.d: New.
112 * testsuite/binutils-all/x86-64/large-sections-2-x32.d: New.
113
114 2023-07-03 Nick Clifton <nickc@redhat.com>
115
116 * README-how-to-make-a-release: Change some version numbers.
117 * configure: Regenerate.
118 * po/binutils.pot: Regenerate.
119
120 2023-07-03 Nick Clifton <nickc@redhat.com>
121
122 2.41 Branch Point.
123
124 2023-06-30 Nick Clifton <nickc@redhat.com>
125
126 PR 30598
127 * strings.c (set_string_min): New function.
128 (main): Use it.
129 (print_unicode_stream): Calculate buffer size using a size_t.
130
131 2023-06-30 Nick Clifton <nickc@redhat.com>
132
133 PR 30595
134 * strings.c (main): Check for an excessively large minimum string
135 length.
136
137 2023-06-21 Nick Clifton <nickc@redhat.com>
138
139 * testsuite/lib/binutils-common.exp (prune_warnings_extra): Prune
140 warnings about -z execstack creating an executable stack.
141
142 2023-05-30 Nick Clifton <nickc@redhat.com>
143
144 * od-pe.c (targ_info): New array.
145 (get_target_specific_info): New function
146 (decode_machine_number): Retire. Use get_target_specific_info
147 instead.
148 (is_pe_object_magic): Likewise.
149 (dump_pe_file_header): Display more information.
150 Rework layout to be similar to that from 'objdump -p'.
151 Add code to handle larger than normnal AOUT headers.
152
153 2023-05-30 Nick Clifton <nickc@redhat.com>
154
155 * od-pe.c (decode_machine_number): Add ARMMAGIC value of 0xa00.
156 (is_pe_object_magic): Likewise.
157
158 2023-05-26 Nick Clifton <nickc@redhat.com>
159
160 * od-pe.c: New file: Dumps fields in PE format headers.
161 * configure.ac (od_vectors): Add objdump_private_desc_pe for PE
162 format targets.
163 (od_files): Add od-pe for PE format targets.
164 * configure: Regenerate.
165 * Makefile.am (CFILES): Add od-pe.c
166 (EXTRA_objdump_SOURCE): Likewise.
167 * Makefile.in: Generate.
168 * NEWS: Mention the new feature.
169 * doc/binutils.texi: Document the new support.
170 * objdump.c (wide_output): Change from local to global.
171 * objdump.h (wide_output): Prototype.
172 (objdump_private_desc_pe): Prototype.
173 * testsuite/binutils-all/objdump.exp: Add a test of the new feature.
174
175 2023-05-09 Enze Li <enze.li@gmx.com>
176
177 * README: Correct a typo.
178
179 2023-05-02 Nick Clifton <nickc@redhat.com>
180
181 * MAINTAINERS: Remove Dimity Diky as MSP430 maintainer.
182
183 2023-04-20 Nick Clifton <nickc@redhat.com>
184
185 * SECURITY.txt: New file.
186
187 2023-04-19 Nick Clifton <nickc@redhat.com>
188
189 PR 30355
190 * dwarf.c (read_and_display_attr_value): Correctly handle
191 DW_loclistx attributes that index a version 5 .debug_loclists
192 section.
193
194 2023-04-17 Nick Clifton <nickc@redhat.com>
195
196 PR 30142
197 * rescoff.c (write_coff_file): Add the SEC_READONLY flag to the
198 .rsrc section.
199
200 2023-04-11 Nick Clifton <nickc@redhat.com>
201
202 PR 30327
203 * dwarf.c (read_and_display_attr_value): Warn if the number of
204 views is greater than the number of locations.
205
206 PR 30313
207 * dwarf.c (display_debug_lines_decoded): Check for an overlarge
208 number of files or directories.
209
210 PR 30312
211 * dwarf.c (prealloc_cu_tu_list): Always allocate at least one
212 entry.
213
214 PR 30311
215 * readelf.c (uncompress_section_contents): Check for a
216 suspiciously large uncompressed size.
217
218 2023-03-30 Nick Clifton <nickc@redhat.com>
219
220 PR 30284
221 * dwarf.c (read_and_display_attr_value): Detect and ignore
222 negative base values.
223
224 2023-03-23 Frederic Cambus <fred@statdns.com>
225
226 * readelf.c (get_segment_type): Handle PT_OPENBSD_MUTABLE segment
227 type.
228
229 2023-03-14 Nick Clifton <nickc@redhat.com>
230
231 PR 30227
232 * dwarf.c (process_cu_tu_index): Prevent excessive memory
233 allocation when nused is large and ncols is zero.
234
235 2023-02-09 Tom Tromey <tromey@adacore.com>
236
237 * dwarf-mode.el: Bump version to 1.8.
238 (dwarf-insert-substructure): Tighten regexp.
239 (dwarf-refresh-all): New defun.
240 (dwarf-mode-map): Bind "A" to dwarf-refresh-all.
241 (dwarf-mode): Remove old FIXME.
242
243 2023-02-07 Nick Clifton <nickc@redhat.com>
244
245 PR 30080
246 * doc/binutils.texi (nm): Update description of the 'n' symbol
247 type.
248
249 2023-01-31 Nick Clifton <nickc@redhat.com>
250
251 * po/sv.po: Updated Swedish translation.
252
253 2023-01-23 Nick Clifton <nickc@redhat.com>
254
255 * po/sv.po: Updated Swedish translation.
256
257 2023-01-18 Nick Clifton <nickc@redhat.com>
258
259 PR 29993
260 * objcopy.c (merge_gnu_build_notes): Remember the last non-deleted
261 note in order to speed up the scan for matching notes.
262
263 2023-01-16 Nick Clifton <nickc@redhat.com>
264
265 * po/sv.po: Updated Swedish translation.
266
267 2023-01-09 Nick Clifton <nickc@redhat.com>
268
269 * po/bg.po: Updated Bulgarian translation.
270 * po/ro.po: Updated Romainian translation.
271
272 2023-01-05 Nick Clifton <nickc@redhat.com>
273
274 * MAINTAINERS: Remove Stephen Casner as the PDP11 maintainer.
275
276 2023-01-03 Nick Clifton <nickc@redhat.com>
277
278 * po/fr.po: Updated French translation.
279 * po/uk.po: Updated Ukrainian translation.
280
281 2023-01-03 Luis Machado <luis.machado@arm.com>
282
283 * readelf.c (get_note_type): Add support for NT_ARM_SSVE and
284 NT_ARM_ZA note types.
285
286 2022-12-31 Nick Clifton <nickc@redhat.com>
287
288 * 2.40 branch created.
289
290 2022-12-31 Nick Clifton <nickc@redhat.com>
291
292 * po/ro.po: Updated Romanian translation.
293
294 2022-12-21 Nick Clifton <nickc@redhat.com>
295
296 PR 29924
297 * objdump.c (load_specific_debug_section): Check for excessively
298 large sections.
299
300 2022-12-19 Tom Tromey <tromey@adacore.com>
301
302 * dwarf-mode.el (dwarf-do-refresh): Avoid compiler warning.
303
304 2022-12-19 Nick Clifton <nickc@redhat.com>
305
306 PR 29914
307 * dwarf.c (fetch_indexed_value): Fail if the section is not big
308 enough to contain a header size field.
309 (display_debug_addr): Fail if the computed address size is too big
310 or too small.
311
312 2022-12-16 Nick Clifton <nickc@redhat.com>
313
314 PR 29908
315 * dwarf.c (display_debug_addr): Check for corrupt header lengths.
316
317 2022-12-01 Nick Clifton <nickc@redhat.com>
318
319 PR 25202
320 * objcopy.c (copy_object): Set VerilogDataEndianness to the
321 endianness of the input file.
322 (copy_main): Verifiy the value set by the --verilog-data-width
323 option.
324 * testsuite/binutils-all/objcopy.exp: Add tests of the new behaviour.
325 * testsuite/binutils-all/verilog-I4.hex: New file.
326
327 2022-11-21 Nick Clifton <nickc@redhat.com>
328
329 PR 29764
330 * doc/binutils.texi (objdump): Note that the -m option supports
331 the <architecture>:<machine> syntax.
332
333 2022-11-04 Nick Clifton <nickc@redhat.com>
334
335 * README-how-to-make-a-release: Add instructions for uploading the
336 gprofng documentation.
337
338 2022-10-31 Nick Clifton <nickc@redhat.com>
339
340 PR 29457
341 * configure.ac: Add --enable-colored-disassembly.
342 * objdump.c: Add --disassembler-color=terminal.
343 * doc/binutils.texi (objdump): Document the new option.
344 * NEWS: Mention new feature.
345 * config.in: Regenerate in.
346 * configure: Regenerate.
347
348 2022-10-19 Nick Clifton <nickc@redhat.com>
349
350 * MAINTAINERS: Add section on patches, copyright and DCO.
351
352 2022-10-12 Nick Clifton <nickc@redhat.com>
353
354 PR 29665
355 * objcopy.c (copy_object): Use the input filename when
356 reporting that a .gnu_debuglink section already exists.
357
358 2022-10-03 Nick Clifton <nickc@redhat.com>
359
360 * readelf.c (get_32bit_section_headers): Return false if the
361 e_shoff field is zero.
362 (get_64bit_section_headers): Likewise.
363
364 2022-09-28 Nick Clifton <nickc@redhat.com>
365
366 PR 29628
367 * size.c (usage): Add -f.
368 * doc/binutils.texi (size): Add -f.
369
370 2022-09-20 Nick Clifton <nickc@redhat.com>
371
372 * objcopy.c (copy_object): Do not issue a warning message when
373 encountering empty .gnu.build.attribute sections.
374
375 2022-09-14 Rupesh Potharla <Rupesh.Potharla@amd.com>
376
377 * testsuite/binutils-all/readelf.exp (readelf_wi_test): Extend
378 regexps to allow for output genreated by the Clang compiler.
379
380 2022-09-12 Aaron Merey <amerey@redhat.com>
381
382 * objcopy.c (might_need_separate_debug_info): Add with_source_code to
383 the options that cause this function to return true.
384 (main.c): Add with_source_code to the options that enable
385 dump_any_debugging.
386
387 2022-09-09 Nick Clifton <nickc@redhat.com>
388
389 PR 29532
390 * objcopy.c (setup_section): Leave group sections intact when
391 creating separate debuginfo files.
392
393 2022-09-08 Nick Clifton <nickc@redhat.com>
394
395 PR 29523
396 * dwarf.c (display_debug_lines_decoded): Correctly handle DWARF-5
397 directory and filename tables.
398
399 2022-09-02 Aaron Merey <amerey@redhat.com>
400
401 PR 29075
402 * objdump.c (find_separate_debug): New function. Finds the bfd
403 corresponding to the separate debuginfod of a given bfd.
404 (find_alt_debug): New function. Finds the bfd corresponding to the
405 .gnu_debugaltlink of a given bfd.
406 (slurp_file): Add bfd parameter. If a source file cannot be found
407 attempt to download it from debuginfod, if enabled.
408 (try_print_file_open): Add bfd parameter and pass it to slurp_file.
409 (show_line): If debuginfod is enabled, call
410 bfd_find_nearest_line_with_alt instead of bfd_find_nearest_line.
411
412 2022-09-01 Nick Clifton <nickc@redhat.com>
413
414 PR 29534
415 * dllwrap.c: Replace uses of choose_temp_base() with
416 make_temp_file().
417 * dlltool.c: Likewise.
418 * resrc.c: Likewise.
419
420 2022-08-23 Nick Clifton <nickc@redhat.com>
421
422 PR 29489
423 * dlltool.c (deterministic): New variable.
424 (gen_lib_file): If deterministic is true set the
425 BFD_DETERMINISTIC_OUTPUT flag.
426 (usage): Mention --deterministic-libraries and
427 --non-deterministic-libraries.
428 (long_options): Add new options.
429 (main): Parse new options.
430 * doc/binutils.texi: Document the new options.
431 * NEWS: Mention the new feature.
432
433 2022-08-22 Nick Clifton <nickc@redhat.com>
434
435 * readelf.c (check_magic_number): New function. Checks the magic
436 bytes at the start of a file. If they are not the ELF format
437 magic values, then attempts to generate a helpful error message.
438 (process_file_header): Call check_magic_number.
439
440 2022-08-09 Nick Clifton <nickc@redhat.com>
441
442 PR 29457
443 * objdump.c (disassembler_color): Change type to an enum.
444 (disassembler_extended_color): Remove.
445 (usage): Update.
446 (objdump_color_for_assembler_style): Update.
447 (main): Update initialisation of disassembler_color. If not
448 initialised via a command line option, set based upon terminal
449 output.
450 * doc/binutils.texi: Update description of disassmbler-color
451 option.
452 * testsuite/binutils-all/arc/objdump.exp: Add
453 --disassembler-color=off option when disassembling.
454 * testsuite/binutils-all/arm/objdump.exp: Likewise.
455
456 2022-08-08 Nick Clifton <nickc@redhat.com>
457
458 * README-how-to-make-a-release: Add a link to the NEWS files in
459 the release announcement email.
460
461 2022-07-08 Nick Clifton <nickc@redhat.com>
462
463 * 2.39 branch created.
464
465 2022-07-01 Nick Clifton <nickc@redhat.com>
466
467 * dwarf.c (display_debug_rnglists): Add newline at end of listing.
468
469 2022-06-30 Nick Clifton <nickc@redhat.com>
470
471 * dwarf.c (dwarf_select_sections_by_name): If the entry's value is
472 zero then clear the corresponding variable.
473 (dwarf_select_sections_by_letters): Likewise.
474 * testsuite/binutils-all/debuginfo.exp: Expect -WE and -wE
475 debuginfod tests to fail.
476
477 2022-06-28 Nick Clifton <nickc@redhat.com>
478
479 PR 29267
480 * dwarf.c (display_debug_rnglists): New function, broken out of..
481 (display_debug_ranges): ... here.
482 (read_and_display_attr_value): Correct calculation of index
483 displayed for DW_FORM_loclistx and DW_FORM_rnglistx.
484 * testsuite/binutils-all/x86-64/pr26808.dump: Update expected
485 output.
486
487 2022-06-27 Nick Clifton <nickc@redhat.com>
488
489 PR 29289
490 * dwarf.c (display_debug_names): Replace assert with a warning
491 message.
492
493 2022-06-27 Nick Clifton <nickc@redhat.com>
494
495 PR 29290
496 * dwarf.c (read_and_display_attr_value): Check that debug_info_p
497 is set before dereferencing it.
498
499 2022-06-27 Nick Clifton <nickc@redhat.com>
500
501 * dwarf.c (fetch_indexed_string): Do not use length of first table
502 in string section as the length of every table in the section.
503
504 * testsuite/binutils-all/pr26112.r: Update expected output.
505
506 2022-06-22 Kumar N, Bhuvanendra <Kavitha.Natarajan@amd.com>
507
508 * dwarf.c (fetch_indexed_string): Added new parameter
509 str_offsets_base to calculate the string offset.
510 (read_and_display_attr_value): Read DW_AT_str_offsets_base
511 attribute.
512 (process_debug_info): While allocating memory and initializing
513 debug_information, do it for do_debug_info also, if its true.
514 (load_separate_debug_files): Load .debug_str_offsets if exists.
515 * dwarf.h (struct debug_info): Add str_offsets_base field.
516
517 2022-06-22 Marcus Nilsson <brainbomb@gmail.com>
518
519 * readelf.c: (slurp_relr_relocs) Use malloc instead of xmalloc
520 when allocating space for relocations.
521
522 2022-06-21 Kumar N, Bhuvanendra <Kavitha.Natarajan@amd.com>
523
524 * dwarf.h (struct debug_info): Add rnglists_base field.
525 * dwarf.c (read_and_display_attr_value): Read attribute DW_AT_rnglists_base.
526 (display_debug_rnglists_list): While handling DW_RLE_base_addressx,
527 DW_RLE_startx_endx, DW_RLE_startx_length items, pass the proper parameter
528 value to fetch_indexed_addr(), i.e. fetch the proper entry in .debug_addr section.
529 (display_debug_ranges): Add rnglists_base to the .debug_rnglists base address.
530 (load_separate_debug_files): Load .debug_addr section, if exists.
531
532 2022-05-20 Nick Clifton <nickc@redhat.com>
533
534 * dwarf.c (dwarf_select_sections_by_names): Return zero if no
535 sections were selected.
536 (dwarf_select_sections_by_letters): Likewise.
537 * dwarf.h: (dwarf_select_sections_by_names): Update prototype.
538 (dwarf_select_sections_by_letters): Update prototype.
539 * objdump.c (might_need_separate_debug_info): New function.
540 (dump_bfd): Call new function before attempting to load separate
541 debug info files.
542 (main): Do not enable dwarf section dumping for -WK or -WN.
543 * readelf.c (parse_args): Do not enable dwarf section dumping for
544 -wK or -wN.
545 (might_need_separate_debug_info): New function.
546 (process_object): Call new function before attempting to load
547 separate debug info files.
548 * testsuite/binutils-all/debuginfo.exp: Expect -WE and -wE
549 debuginfod tests to pass.
550 * testsuite/binutils-all/objdump.Wk: Add extra regexps.
551 * testsuite/binutils-all/readelf.k: Add extra regexps.
552
553 2022-05-19 Nick Clifton <nickc@redhat.com>
554
555 * dlltool.c (run): Initialise errmsg_fmt.
556 * dllwrap.c (run): Likewise.
557 * resrc.c (run_cmd): Likewise.
558 * mclex.c (mc_add_keyword): Initialise usz.
559 * srconv.c (wd_hd): Initialise hd.spare2.
560 * windmc.c (mc_add_node_lang): Initialise s.
561 (mc_generate_bin_item): Initialise cvt_txt.
562 (main): Initialise u.
563
564 2022-05-18 Nick Clifton <nickc@redhat.com>
565
566 PR 29135
567 * nm.c (non_weak): New variable.
568 (filter_symbols): When non-weak is true, ignore weak symbols.
569 (long_options): Add --no-weak.
570 (usage): Mention --no-weak.
571 (main): Handle -W/--no-weak.
572 * doc/binutils.texi: Document new feature.
573 * NEWS: Mention the new feature.
574 * testsuite/binutils-all/nm.exp: Add test of new feature.
575 * testsuite/binutils-all/no-weak.s: New test source file.
576
577 2022-04-25 Nick Clifton <nickc@redhat.com>
578
579 PR 29072
580 * testsuite/lib/binutils-common.exp (prune_warnings_extra): Filter
581 out notes about the executable stacjk behaviour beign deprecated.
582
583 2022-04-12 Nick Clifton <nickc@redhat.com>
584
585 PR 28992
586 * objcopy.c (is_strip_section_1): Do not delete debuglink sections
587 when stripping debug information.
588
589 2022-04-06 Nick Clifton <nickc@redhat.com>
590
591 PR 28981
592 * dwarf.c (fetch_indexed_value): Rename to fecth_indexed_addr and
593 return the address, rather than a string.
594 (fetch_indexed_value): New function - returns a value indexed by a
595 DW_FORM_loclistx or DW_FORM_rnglistx form.
596 (read_and_display_attr_value): Add support for DW_FORM_loclistx
597 and DW_FORM_rnglistx.
598 (process_debug_info): Load the loclists and rnglists sections.
599 (display_loclists_list): Add support for DW_LLE_base_addressx,
600 DW_LLE_startx_endx, DW_LLE_startx_length and
601 DW_LLE_default_location.
602 (display_offset_entry_loclists): New function. Displays a
603 .debug_loclists section that contains offset entry tables.
604 (display_debug_loc): Call the new function.
605 (display_debug_rnglists_list): Add support for
606 DW_RLE_base_addressx, DW_RLE_startx_endx and DW_RLE_startx_length.
607 (display_debug_ranges): Display the contents of the section's
608 header.
609 * dwarf.h (struct debug_info): Add loclists_base field.
610 * testsuite/binutils-all/dw5.W: Update expected output.
611 * testsuite/binutils-all/x86-64/pr26808.dump: Likewise.
612
613 2022-04-01 John Baldwin <jhb@FreeBSD.org>
614
615 * readelf.c (get_freebsd_elfcore_note_type): Handle
616 NT_FREEBSD_X86_SEGBASES.
617
618 2022-03-31 Nick Clifton <nickc@redhat.com>
619
620 * arlex.l: Accept the plus character as part of a filename.
621
622 2022-03-16 Fangrui Song <maskray@google.com>
623
624 PR binutils/28926
625 * objcopy.c (filter_symbols): Apply weaken to STB_GNU_UNIQUE symbols
626 * NEWS: Mention feature.
627 * testsuite/binutils-all/objcopy.exp (objcopy_test_symbol_manipulation): New test.
628 * testsuite/binutils-all/weaken-gnu-unique.s: New.
629
630 2022-03-16 Martin Storsjö <martin@martin.st>
631
632 PR 28885
633 * dlltool.c (main): use imp_name rather than dll_name when
634 generating a temporary file name.
635
636 2022-03-16 Simon Marchi <simon.marchi@efficios.com>
637
638 * readelf.c (dump_relocations): Handle EM_AMDGPU.
639
640 2022-03-16 Simon Marchi <simon.marchi@efficios.com>
641
642 * Makefile.am (readelf_CFLAGS): New.
643 (readelf_LDADD): Add MSGPACK_LIBS.
644 * Makefile.in: Re-generate.
645 * config.in: Re-generate.
646 * configure: Re-generate.
647 * configure.ac: Add --with-msgpack flag and check for msgpack
648 using pkg-config.
649 * readelf.c: Include msgpack.h if HAVE_MSGPACK.
650 (print_note_contents_hex): New.
651 (print_indents): New.
652 (dump_msgpack_obj): New.
653 (dump_msgpack): New.
654 (print_amdgpu_note): New.
655 (process_note): Handle NT_AMDGPU_METADATA note contents.
656 Use print_note_contents_hex.
657
658 2022-03-16 Simon Marchi <simon.marchi@efficios.com>
659
660 * readelf.c (get_amdgpu_elf_note_type): New.
661 (process_note): Handle "AMDGPU" notes.
662
663 2022-03-16 Simon Marchi <simon.marchi@efficios.com>
664
665 * readelf.c: Include elf/amdgcn.h.
666 (decode_AMDGPU_machine_flags): New.
667 (get_machine_flags): Handle flags for EM_AMDGPU machine type.
668
669 2022-03-16 Simon Marchi <simon.marchi@efficios.com>
670
671 * readelf.c (get_osabi_name): Handle EM_AMDGPU OS ABIs.
672
673 2022-03-16 Nick Clifton <nickc@redhat.com>
674
675 * po/sr.po: Updated Serbian translation.
676
677 2022-03-15 Tom Tromey <tromey@adacore.com>
678
679 * dwarf-mode.el: Now 1.7.
680 (dwarf--sentinel): Switch to the process buffer.
681
682 2022-03-11 Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
683
684 * MAINTAINERS: Add gprofng maintainer.
685 * README-how-to-make-a-release: Add gprofng.
686
687 2022-03-10 Nick Clifton <nickc@redhat.com>
688
689 * dwarf.c (use_debuginfod): New variable. Set to 1.
690 (load_separate_debug_info): Only call
691 debuginfod_fetch_separate_debug_info is use_debuginfod is true.
692 (dwarf_select_sections_by_names): Add do-not-use-debuginfod and
693 use-debuginfod options.
694 (dwarf_select_sections_by_letters): Add D and E options.
695 * dwarf.h (use_debuginfod): New extern.
696 * objdump.c (usage): Mention the new options.
697 * readelf.c (usage): Likewise.
698 * doc/binutils.texi: Document the new options.
699 * doc/debug-options.texi: Describe the new options.
700 * NEWS: Mention the new feature.
701 * testsuite/binutils-all/debuginfod.exp: Add tests of the new
702 options.
703
704 2021-03-06 Maciej W. Rozycki <macro@orcam.me.uk>
705
706 * testsuite/binutils-all/mips/mips1-branch-alias.d: New test.
707 * testsuite/binutils-all/mips/mips1-branch-noalias.d: New test.
708 * testsuite/binutils-all/mips/mips2-branch-alias.d: New test.
709 * testsuite/binutils-all/mips/mips2-branch-noalias.d: New test.
710 * testsuite/binutils-all/mips/mips32r6-branch-alias.d: New test.
711 * testsuite/binutils-all/mips/mips32r6-branch-noalias.d: New
712 test.
713 * testsuite/binutils-all/mips/micromips-branch-alias.d: New
714 test.
715 * testsuite/binutils-all/mips/micromips-branch-noalias.d: New
716 test.
717 * testsuite/binutils-all/mips/mips-branch-alias.s: New test
718 source.
719 * testsuite/binutils-all/mips/micromips-branch-alias.s: New test
720 source.
721 * testsuite/binutils-all/mips/mips.exp: Run the new tests.
722
723 2022-03-04 Simon Marchi <simon.marchi@polymtl.ca>
724
725 * readelf.c (process_dynamic_section): Fix indentation.
726
727 2022-02-09 Nick Clifton <nickc@redhat.com>
728
729 * README-how-to-make-a-release: Update after the 2.38 release.
730
731 2022-01-27 Nick Clifton <nickc@redhat.com>
732
733 * po/sv.po: Updated Swedish translation.
734
735 2022-01-24 Nick Clifton <nickc@redhat.com>
736
737 * po/bg.po: Updated Bulgarian translation.
738 * po/fr.po: Updated French translation.
739 * po/ro.po: Updated Romanian translation.
740 * po/uk.po: Updated Ukranian translation.
741
742 2022-01-22 Martin Storsjö <martin@martin.st>
743
744 * dlltool.c (main): Allow inferring tmp_prefix from the dll name
745 from a def file.
746
747 2022-01-22 Nick Clifton <nickc@redhat.com>
748
749 * configure: Regenerate.
750 * po/binutils.pot: Regenerate.
751
752 2022-01-22 Nick Clifton <nickc@redhat.com>
753
754 * 2.38 release branch created.
755
756 2022-01-17 Nick Clifton <nickc@redhat.com>
757
758 * Makefile.in: Regenerate.
759
760 2022-01-11 Fangrui Song <maskray@google.com>
761
762 PR binutils/28759
763 * ar.c (long_options): Add --thin.
764 (usage) Add --thin. Deprecate -T without diagnostics.
765 * doc/binutils.texi: Add doc.
766 * NEWS: Mention --thin.
767 * binutils/testsuite/binutils-all/ar.exp: Add tests.
768
769 2022-01-11 Martin Storsjö <martin@martin.st>
770
771 * dlltool.c (main): If a prefix has not been provided, attempt to
772 use a deterministic one based upon the dll name.
773
774 2022-01-07 Pavel Mayorov <pmayorov@cloudlinux.com>
775
776 PR 28718
777 * dwarf.c: Revert previous delta.
778 (debug_get_real_type): Reject indirect types that point to
779 indirect types.
780 (debug_get_type_name, debug_get_type_size, debug_write_type):
781 Likewise.
782
783 2022-01-06 Nick Clifton <nickc@redhat.com>
784
785 * debug.c (debug_write_type): Allow for malicious recursion via
786 indirect debug types.
787
788 2022-01-04 Nick Clifton <nickc@redhat.com>
789
790 PR 28716
791 * dwarf.c (load_build_id_debug_file): Remove spurious printf.
792
793 2021-12-16 Nick Clifton <nickc@redhat.com>
794
795 PR 28697
796 * dwarf.c (load_build_id_debug_file): New function.
797 (try_build_id_prefix): New function.
798 (check_for_and_load_links): Call load_build_id_debug_file.
799 (debug_displays): Add entry for .note.gnu.build-id.
800 * dwarf.h (enum dwarf_section_display_enum): Add
801 note_gnu_build_id.
802 * testsuite/binutils-all/debuginfod.exp (test_fetch_debuglink):
803 Fix regexp for loads via debuglink section.
804
805 2021-12-03 Chenghua Xu <xuchenghua@loongson.cn>
806
807 * MAINTAINERS: Add myself and Zhensong Liu
808 as the LoongArch maintainer.
809
810 2021-12-02 Nick Clifton <nickc@redhat.com>
811
812 PR 28645
813 * dwarf.c (process_cu_tu_index): Add test for overruning section
814 whilst processing slots.
815
816 2021-11-30 Roland McGrath <mcgrathr@google.com>
817
818 * doc/local.mk: Give each man page target its missing dependency on
819 doc/$(am__dirstamp).
820
821 2021-11-30 Nick Clifton <nickc@redhat.com>
822
823 * dwarf.c (find_debug_info_for_offset): Use dwarf_vma type for
824 offsets, sizes and ranges.
825 (display_loc_list): Likewise. Also use print_dwarf_vma to print
826 the offset.
827 (display_loclists_list): Likewise.
828 (display_loc_list_dwo): Likewise.
829 (display_debug_str): Likewise.
830 (display_debug_aranges): Likewise.
831 (display_debug_ranges_list): Likewise.
832 (display_debug_rnglists_list): Likewise.
833 (display_debug_ranges): Likewise.
834
835 2021-11-29 Nick Clifton <nickc@redhat.com>
836
837 PR 28632
838 * strings.c (usage): Update desciption of -n option.
839 * doc/binutils.texi: Likewise.
840
841 2021-11-24 Nick Clifton <nickc@redhat.com>
842
843 PR 28564
844 * sysdump.c (getCHARS): Check for an out of bounds read.
845
846 2021-11-16 Fangrui Song <maskray@google.com>
847
848 * readelf.c (enum relocation_type): New.
849 (slurp_relr_relocs): New.
850 (dump_relocations): Change is_rela to rel_type.
851 Dump RELR.
852 (dynamic_relocations): Add DT_RELR.
853 (process_relocs): Check SHT_RELR and DT_RELR.
854 (process_dynamic_section): Store into dynamic_info for
855 DT_RELR/DT_RELRENT/DT_RELRSZ.
856
857 2021-11-09 Nick Clifton <nickc@redhat.com>
858
859 * nm.c: Add --unicode option to control how unicode characters are
860 handled.
861 * objdump.c: Likewise.
862 * readelf.c: Likewise.
863 * strings.c: Likewise.
864 * binutils.texi: Document the new feature.
865 * NEWS: Document the new feature.
866 * testsuite/binutils-all/unicode.exp: New file.
867 * testsuite/binutils-all/nm.hex.unicode
868 * testsuite/binutils-all/strings.escape.unicode
869 * testsuite/binutils-all/objdump.highlight.unicode
870 * testsuite/binutils-all/readelf.invalid.unicode
871
872 2021-11-03 Tom Tromey <tromey@adacore.com>
873
874 * dwarf.c (display_debug_loc): Use section name in warnings.
875
876 2021-10-25 Nick Alcock <nick.alcock@oracle.com>
877
878 * objdump.c (usage): --ctf now has an optional argument.
879 (main): Adjust accordingly.
880 (dump_ctf): Default it.
881 * doc/ctf.options.texi: Adjust.
882
883 2021-10-25 Nick Alcock <nick.alcock@oracle.com>
884
885 * objdump.c (usage): --ctf-parent now takes a name, not a section.
886 (dump_ctf): Don't open a separate section; use the parent_name in
887 ctf_dict_open instead. Use ctf_archive_next, not ctf_archive_iter,
888 so we can pass down a member count.
889 (dump_ctf_archive_member): Add the member count; don't return
890 anything. Import parents into children no matter what the
891 parent's name, while still avoiding displaying the header for the
892 common parent name of ".ctf".
893 * readelf.c (usage): Adjust similarly.
894 (dump_section_as_ctf): Likewise.
895 (dump_ctf_archive_member): Likewise. Never stop iterating over
896 archive members, even if ctf_dump of one member fails.
897 * doc/ctf.options.texi: Adjust.
898
899 2021-10-19 Nick Clifton <nickc@redhat.com>
900
901 * nm.c (filter_symbols): Test for a NULL name before checking to
902 see if the symbol is __gnu_lto_slim.
903 * objcopy.c (filter_symbols): Likewise.
904
905 2021-09-30 Nick Clifton <nickc@redhat.com>
906
907 * objcopy.c (filter_symbols): Fail if attempting to dredefine
908 symbols in an LTO object file.
909
910 2021-09-27 Nick Alcock <nick.alcock@oracle.com>
911
912 * configure: Regenerate.
913
914 2021-09-20 Andrew Burgess <andrew.burgess@embecosm.com>
915
916 * testsuite/binutils-all/riscv/riscv.exp: New file.
917 * testsuite/binutils-all/riscv/unknown.d: New file.
918 * testsuite/binutils-all/riscv/unknown.s: New file.
919
920 2021-09-07 Luis Machado <luis.machado@linaro.org>
921
922 Revert: [AArch64] MTE corefile support
923
924 2021-05-21 Luis Machado <luis.machado@linaro.org>
925
926 * readelf.c (get_note_type): Handle NT_MEMTAG note types.
927
928 2021-08-11 Nick Clifton <nickc@redhat.com>
929
930 * po/pt.po: Updated Portuguese translation.
931
932 2021-08-10 Nick Clifton <nickc@redhat.com>
933
934 * po/sr.po: Updated Serbian translation.
935
936 2021-07-16 Nick Clifton <nickc@redhat.com>
937
938 * po/sv.po: Updated Swedish translation.
939
940 2021-07-14 Clément Chigot <clement.chigot@atos.net>
941
942 * dwarf.h (struct dwarf_section): Add XCOFF name.
943 * dwarf.c (struct dwarf_section_display): Update.
944 * objdump.c (load_debug_section): Add XCOFF name handler.
945 (dump_dwarf_section): Likewise.
946
947 2021-07-12 Nick Clifton <nickc@redhat.com>
948
949 * po/fr.po: Updated French translation.
950
951 2021-07-10 Alan Modra <amodra@gmail.com>
952
953 PR 28069
954 * dwarf.c (display_discr_list): Remove assertions. Delete "end"
955 parameter, use initial "data" pointer as the end. Formatting.
956 Don't count down bytes as they are read.
957 (read_and_display_attr_value): Adjust display_discr_list call.
958 (read_and_print_leb128): Don't pass __FILE__ and __LINE__ to
959 report_leb_status.
960 * dwarf.h (report_leb_status): Don't report file and line
961 numbers. Delete file and lnum parameters,
962 (READ_ULEB, READ_SLEB): Adjust.
963
964 2021-07-07 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
965
966 * configure.ac: Check for strnlen declaration.
967 * configure, config.in: Regenerate.
968
969 2021-07-05 Alan Modra <amodra@gmail.com>
970
971 PR 28047
972 * dwarf.c (get_type_abbrev_from_form): Add cu_end parameter.
973 Check DW_FORM_ref1 etc. arg against cu_end rather than end of
974 section. Adjust all callers.
975
976 2021-07-03 Nick Clifton <nickc@redhat.com>
977
978 * configure: Regenerate.
979 * po/opcodes.pot: Regenerate.
980 * README-how-to-make-a-release: Update.
981
982 2021-07-03 Nick Clifton <nickc@redhat.com>
983
984 * 2.37 release branch created.
985
986 2021-07-02 Alan Modra <amodra@gmail.com>
987
988 PR 28048
989 * dwarf.c (get_type_signedness): Don't run off end of buffer
990 printing DW_FORM_string attribute.
991
992 2021-07-01 Nick Clifton <nickc@redhat.com>
993
994 PR 28029
995 * testsuite/binutils-all/debuginfod.exp: Replace -wK with -wk.
996
997 2021-07-01 Andrei Homescu <ah@immunant.com>
998
999 * readelf.c (process_archive): Reset file position to the
1000 beginning when calling process_object for thin archive members.
1001 * testsuite/binutils-all/readelf.exp: Add test.
1002 * testsuite/binutils-all/readelf.h.thin: New file.
1003
1004 2021-06-30 Tom Tromey <tom@tromey.com>
1005
1006 * dwarf.c (read_and_display_attr_value): Handle
1007 DW_FORM_implicit_const.
1008
1009 2021-06-30 Richard Henderson <richard.henderson@linaro.org>
1010
1011 * dwarf.c (display_debug_frames): Both DW_CFA_def_cfa_sf
1012 and DW_CFA_def_cfa_offset_sf have a signed offset.
1013
1014 2021-06-19 Alan Modra <amodra@gmail.com>
1015
1016 * dwarf.c (display_debug_lines_decoded): Use memcpy rather than
1017 strncpy when trimming file name length to MAX_FILENAME_LENGTH.
1018 Don't make an unnecessary copy when length is good.
1019
1020 2021-06-18 H.J. Lu <hongjiu.lu@intel.com>
1021
1022 * readelf.c (print_gnu_property_note): Handle
1023 GNU_PROPERTY_UINT32_AND_LO, GNU_PROPERTY_UINT32_AND_HI,
1024 GNU_PROPERTY_UINT32_OR_LO and GNU_PROPERTY_UINT32_OR_HI.
1025
1026 2021-06-15 Nick Clifton <nickc@redhat.com>
1027
1028 * readelf.c (get_note_type): Add support for NT_GO_BUILDID.
1029
1030 2021-06-15 Alan Modra <amodra@gmail.com>
1031
1032 * readelf.c (locate_dynamic_section, is_pie): New functions.
1033 (get_file_type): Replace e_type parameter with filedata. Call
1034 is_pie for ET_DYN. Update all callers.
1035 (process_program_headers): Use local variables dynamic_addr and
1036 dynamic_size, updating filedata on exit from function. Set
1037 dynamic_size of 1 to indicate no dynamic section or segment.
1038 Update tests of dynamic_size throughout.
1039 * testsuite/binutils-all/x86-64/pr27708.dump: Update expected output.
1040
1041 2021-06-14 Eric Botcazou <ebotcazou@adacore.com>
1042
1043 * dwarf.c (struct abbrev_attr): Change type of implicit_const.
1044 (add_abbrev_attr): Likewise.
1045 (process_abbrev_set): Likewise.
1046 (display_debug_abbrev): Adjust to above change.
1047
1048 2021-06-12 Alan Modra <amodra@gmail.com>
1049
1050 * readelf.c (process_file_header): Don't clear section_headers.
1051
1052 2021-06-12 Alan Modra <amodra@gmail.com>
1053
1054 * readelf.c (get_section_headers): Don't test e_shoff here, leave
1055 that to get_32bit_section_headers or get_64bit_section_headers.
1056 (process_object): Throw away section header read to print file
1057 header extension.
1058
1059 2021-06-11 Alan Modra <amodra@gmail.com>
1060
1061 * readelf.c (struct filedata): Move archive_file_offset and
1062 archive_file_size earlier.
1063 (free_filedata): Clear using memset.
1064
1065 2021-06-11 Alan Modra <amodra@gmail.com>
1066
1067 * readelf.c (GET_ELF_SYMBOLS): Delete. Replace with..
1068 (get_elf_symbols): ..this new function throughout.
1069 (get_32bit_section_headers): Don't free section_headers.
1070 (get_64bit_section_headers): Likewise.
1071 (get_section_headers): New function, use throughout in place of
1072 32bit and 64bit variants.
1073 (get_dynamic_section): Similarly.
1074 (process_section_headers): Don't free filedata memory here.
1075 (get_file_header): Don't get section headers here..
1076 (process_object): ..Read them here instead. Don't exit without
1077 freeing filedata memory.
1078
1079 2021-06-09 Nick Clifton <nickc@redhat.com>
1080
1081 * MAINTAINERS: Remove Daniel Jacobwitz from the maintainers list.
1082
1083 2021-06-07 Jan Beulich <jbeulich@suse.com>
1084
1085 * dwarf.c (display_debug_aranges): Add u suffix to constant.
1086
1087 2021-05-29 Alan Modra <amodra@gmail.com>
1088
1089 * objdump (usage): Add missing \n.
1090
1091 2021-05-29 Alan Modra <amodra@gmail.com>
1092
1093 * readelf.c (parse_args): Call dwarf_select_sections_all on
1094 --debug-dump without optarg.
1095 (usage): Associate -w and --debug-dump options closely.
1096 Split up help message. Remove extraneous blank lines around
1097 ctf help.
1098 * objdump.c (usage): Similarly.
1099
1100 2021-05-29 Maciej W. Rozycki <macro@orcam.me.uk>
1101
1102 * testsuite/binutils-all/mips/mips-xpa-virt-1.d: Correct CFC0
1103 operand disassembly.
1104 * testsuite/binutils-all/mips/mips-xpa-virt-3.d: Likewise.
1105
1106 2021-05-29 Maciej W. Rozycki <macro@orcam.me.uk>
1107
1108 * testsuite/binutils-all/mips/mips-xpa-virt-1.d: Use `mips:3000'
1109 machine for disassembly.
1110 * testsuite/binutils-all/mips/mips-xpa-virt-2.d: Likewise.
1111 * testsuite/binutils-all/mips/mips-xpa-virt-3.d: Likewise.
1112 * testsuite/binutils-all/mips/mips-xpa-virt-4.d: Likewise.
1113
1114 2021-05-28 H.J. Lu <hongjiu.lu@intel.com>
1115
1116 PR ld/27905
1117 * readelf.c (decode_x86_feature_2): Revert commit 50c95a739c9.
1118
1119 2021-05-27 Alan Modra <amodra@gmail.com>
1120
1121 * readelf (usage): Order -w letters to match --debug-dump= and
1122 move common '=' for --debug-dump out of brackets.
1123
1124 2021-05-26 H.J. Lu <hongjiu.lu@intel.com>
1125
1126 PR ld/27905
1127 * readelf.c (decode_x86_feature_2): Support
1128 GNU_PROPERTY_X86_FEATURE_2_CODE16.
1129
1130 2021-05-23 Tiezhu Yang <yangtiezhu@loongson.cn>
1131
1132 * readelf.c (get_machine_name): Change Loongson Loongarch to
1133 LoongArch.
1134
1135 2021-05-21 Luis Machado <luis.machado@linaro.org>
1136
1137 * readelf.c (get_note_type): Add missing NT_ARM_* entries.
1138
1139 2021-05-21 Luis Machado <luis.machado@linaro.org>
1140
1141 * readelf.c (get_note_type): Handle NT_MEMTAG note types.
1142
1143 2021-05-19 Eli Schwartz <eschwartz@archlinux.org>
1144
1145 * dwarf.c (ENABLE_CHECKING): Define to 0 if not previously set.
1146
1147 2021-05-19 Alan Modra <amodra@gmail.com>
1148
1149 PR 27884
1150 * dwarf.c (get_type_abbrev_from_form): Replace cu_offset_return
1151 param with map_return, and return map for DW_FORM_ref_addr.
1152 (get_type_signedness): Adjust calls to get_type_abbrev_from_form.
1153 Pass returned cu map start and end to recursive call.
1154 (read_and_display_attr_value): Similarly.
1155
1156 2021-05-19 Alan Modra <amodra@gmail.com>
1157
1158 PR 27879
1159 * sysdump.c (getBARRAY): Sanity check size against max.
1160 (getINT): Avoid UB shift left.
1161
1162 2021-05-15 Alan Modra <amodra@gmail.com>
1163
1164 * dwarf.c (process_cu_tu_index): Avoid pointer UB. Use _mul_overflow.
1165 Delete dead code.
1166
1167 2021-05-15 Alan Modra <amodra@gmail.com>
1168
1169 * dwarf.c (display_gdb_index): Avoid pointer UB and overflow in
1170 length calculations.
1171
1172 2021-05-15 Alan Modra <amodra@gmail.com>
1173
1174 * dwarf.c (display_debug_names): Complain when header length is
1175 too small. Avoid pointer UB. Sanity check augmentation string,
1176 CU table, TU table and foreign TU table sizes.
1177
1178 2021-05-15 Alan Modra <amodra@gmail.com>
1179
1180 * dwarf.c (display_debug_frames): Delete initial_length_size.
1181 Avoid pointer UB. Constrain data reads to length given in header.
1182 Sanity check cie header length. Only skip up to next FDE on
1183 finding augmentation data too long.
1184
1185 2021-05-15 Alan Modra <amodra@gmail.com>
1186
1187 * dwarf.c (read_cie): Add more sanity checks to ensure data
1188 pointer is not bumped past end.
1189
1190 2021-05-15 Alan Modra <amodra@gmail.com>
1191
1192 * dwarf.c (display_debug_ranges): Delete initial_length_size.
1193 Correct fallback size calculated on finding a reloc. Constrain
1194 data reads to length given in header. Avoid pointer UB.
1195
1196 2021-05-15 Alan Modra <amodra@gmail.com>
1197
1198 * dwarf.c (display_debug_rnglists_list): Avoid pointer UB.
1199
1200 2021-05-15 Alan Modra <amodra@gmail.com>
1201
1202 * dwarf.c (display_debug_str_offsets): Constrain reads to length
1203 given in header.
1204
1205 2021-05-15 Alan Modra <amodra@gmail.com>
1206
1207 * dwarf.c (display_debug_aranges): Delete initial_length_size.
1208 Use end_ranges to constrain data reads to header length. Avoid
1209 pointer UB.
1210
1211 2021-05-15 Alan Modra <amodra@gmail.com>
1212
1213 * dwarf.c (display_loc_list): Avoid pointer UB. Correct check
1214 before reading uleb length. Warn on excess length.
1215
1216 2021-05-15 Alan Modra <amodra@gmail.com>
1217
1218 * dwarf.c (display_debug_macro): Print strings that might not
1219 be zero terminated with %*s. Don't bump curr if unterminated.
1220
1221 2021-05-15 Alan Modra <amodra@gmail.com>
1222
1223 * dwarf.c (get_line_filename_and_dirname): Delete initial_length_size.
1224 Simplify length sanity check, and check for too small lengths.
1225 Constrain data reads to header length. Avoid pointer UB.
1226
1227 2021-05-15 Alan Modra <amodra@gmail.com>
1228
1229 * dwarf.c (display_debug_macinfo): Print strings that might not
1230 be zero terminated with %*s. Don't bump curr if unterminated.
1231
1232 2021-05-15 Alan Modra <amodra@gmail.com>
1233
1234 * dwarf.c (display_debug_pubnames_worker): Delete initial_length_size.
1235 Simplify length check. Constrain reads to length given by header.
1236
1237 2021-05-15 Alan Modra <amodra@gmail.com>
1238
1239 * dwarf.c (display_debug_lines_decoded): Don't use strnlen when
1240 we have already checked for NUL termination.
1241
1242 2021-05-15 Alan Modra <amodra@gmail.com>
1243
1244 * dwarf.c (read_debug_line_header): Delete initial_length_size.
1245 Avoid pointer UB. Keep within length specified by header.
1246 Delete dead code.
1247
1248 2021-05-15 Alan Modra <amodra@gmail.com>
1249
1250 * dwarf.c (process_debug_info): Always do the first CU length
1251 scan for sanity checks. Remove initial_length_size var and
1252 instead calculate end_cu. Use end_cu to limit data reads.
1253 Delete now dead code checking length.
1254
1255 2021-05-15 Alan Modra <amodra@gmail.com>
1256
1257 * dwarf.c (SAFE_BYTE_GET_INTERNAL): Assert only when ENABLE_CHECKING.
1258
1259 2021-05-15 Alan Modra <amodra@gmail.com>
1260
1261 * bucomm.h (_mul_overflow): Define.
1262 * dwarf.c (get_encoded_value): Avoid pointer UB.
1263
1264 2021-05-13 Alan Modra <amodra@gmail.com>
1265
1266 PR 27861
1267 * dwarf.c (display_debug_str_offsets): Sanity check dwarf5
1268 header length.
1269
1270 2021-05-13 Alan Modra <amodra@gmail.com>
1271
1272 PR 27860
1273 * dwarf.c (display_debug_frames): Sanity check cie_off before
1274 attempting to read cie.
1275
1276 2021-05-12 Alan Modra <amodra@gmail.com>
1277
1278 * dwarf.c (process_extended_line_op): Don't bump data pointer past
1279 end when strnlen doesn't find string terminator.
1280 (decode_location_expression): Remove dead code.
1281 (skip_attr_bytes): Remove const from end param. Ensure data
1282 pointer doesn't pass end.
1283 (get_type_signedness): Remove const from end param.
1284 (read_and_display_attr_value): Ensure data pointer doesn't pass end.
1285 (display_debug_lines_raw, display_debug_lines_decoded): Likewise.
1286 (display_debug_pubnames_worker): Likewise.
1287 (display_debug_pubnames_worker): Use SAFE_BYTE_GET_AND INC rather
1288 than blindly incrementing data pointer.
1289 (display_debug_addr, display_debug_str_offsets): Likewise. Don't
1290 compare pointers, compare lengths.
1291
1292 2021-05-12 Alan Modra <amodra@gmail.com>
1293
1294 * dwarf.c (SAFE_BYTE_GET_INTERNAL): Define.
1295 (SAFE_BYTE_GET, SAFE_BYTE_GET_AND_INC): Define using the above.
1296 (SAFE_SIGNED_BYTE_GET, SAFE_SIGNED_BYTE_GET_AND_INC): Likewise.
1297 (display_discr_list): Use SAFE_BYTE_GET_AND_INC rather than
1298 SAFE_BYTE_GET followed by increment.
1299 (process_debug_info): Likewise, and test bytes remaining before
1300 incrementing section_begin rather than using pointer comparison.
1301 (display_debug_names): Pass lvalue as SAFE_BYTE_GET PTR.
1302 (process_cu_tu_index): Likewise for SAFE_BYTE_GET_AND_INC.
1303
1304 2021-05-12 Alan Modra <amodra@gmail.com>
1305
1306 * dwarf.c (dwarf_vmatoa64, SAFE_BYTE_GET64, add64): Delete.
1307 (skip_attr_bytes): Replace use of SAFE_BYTE_GET64 with
1308 SAFE_BYTE_GET_AND_INC.
1309 (read_and_display_attr_value): Likewise. Print using dwarf_vmatoa.
1310 (process_debug_info, process_cu_tu_index): Likewise.
1311 * elfcomm.c (byte_put, byte_put_little_endian, byte_put_big_endian),
1312 (byte_get, byte_get_little_endian, byte_get_big_endian),
1313 (byte_get_signed): Make size param unsigned. Remove code dealing
1314 with 4-byte elf_vma.
1315 (byte_get_64): Delete.
1316 * elfcomm.h (byte_put, byte_put_little_endian, byte_put_big_endian),
1317 (byte_get, byte_get_little_endian, byte_get_big_endian),
1318 (byte_get_signed): Update prototypes.
1319 (byte_get_64): Delete.
1320
1321 2021-05-12 Alan Modra <amodra@gmail.com>
1322
1323 PR 27836
1324 * dwarf.c (display_debug_frames): Don't compare pointers derived
1325 from user input. Test offset against bounds instead.
1326
1327 2021-05-12 Alan Modra <amodra@gmail.com>
1328
1329 PR 27853
1330 * dwarf.c (display_formatted_table): Test for data >= end rather
1331 than data == end.
1332 (process_extended_line_op): Likewise.
1333 (display_debug_lines_raw): Likewise.
1334 (display_debug_lines_decoded): Likewise.
1335
1336 2021-05-12 Alan Modra <amodra@gmail.com>
1337
1338 PR 27849
1339 * dwarf.c (fetch_indexed_string): Correct length sanity checks.
1340 Sanity check section size for version and padding too. Correct
1341 index sanity check. Handle multiple tables in .debug_str_offsets.
1342
1343 2021-05-11 Hans-Peter Nilsson <hp@axis.com>
1344
1345 * dwarf.c (process_abbrev_set): Properly parenthesize before
1346 casting to unsigned long.
1347
1348 2021-05-11 Alan Modra <amodra@gmail.com>
1349
1350 PR 27845
1351 * dwarf.c (process_abbrev_set): Replace start and end parameters
1352 with section, abbrev_base, abbrev_size, abbrev_offset. Update
1353 all callers. Sanity check parameters correctly and emit warnings
1354 here rather than..
1355 (process_debug_info): ..here.
1356
1357 2021-05-10 Thomas Wolff <towo@towo.net>
1358
1359 PR 4356
1360 PR 26865
1361 PR 27594
1362 * windres.c (quot): Revert previous delta. Do not use double
1363 quotes when spaces are detected in options.
1364 * doc/binutils.texi (windres): Remove suggestion that the
1365 --preprocessor option can take arguments.
1366
1367 2021-05-10 Alan Modra <amodra@gmail.com>
1368
1369 * dwarf.c (SAFE_BYTE_GET): Check bounds by subtracting amount from
1370 END rather than adding amount to PTR.
1371 (SAFE_SIGNED_BYTE_GET, SAFE_BYTE_GET64): Likewise.
1372
1373 2021-05-09 Alan Modra <amodra@gmail.com>
1374
1375 * objcopy.c (eq_string): Delete.
1376 (create_symbol_htab): Use htab_eq_string.
1377
1378 2021-05-08 Mike Frysinger <vapier@gentoo.org>
1379
1380 * README-how-to-make-a-release: Update html & pdf entries.
1381
1382 2021-05-08 Mike Frysinger <vapier@gentoo.org>
1383
1384 * doc/Makefile.am (html-local, binutils/index.html): New targets.
1385 * doc/Makefile.in: Regenerate.
1386
1387 2021-05-08 Mike Frysinger <vapier@gentoo.org>
1388
1389 * doc/Makefile.am (AM_MAKEINFOFLAGS): Add --no-split.
1390 * doc/Makefile.in: Regenerate.
1391
1392 2021-05-07 Nick Clifton <nickc@redhat.com>
1393
1394 * readelf.c (no_processor_specific_unwind): New function.
1395 (process_unwind): Use no_processor_specific_unwind for X86
1396 targets.
1397
1398 2021-05-07 Michael Forney <mforney@mforney.org>
1399
1400 * dwarf.c: Don't omit second operand of '?' operator.
1401
1402 2021-04-30 Nick Clifton <nickc@redhat.com>
1403
1404 PR 27796
1405 * dwarf.c (load_debug_sup_file): Allocate memory for filename in
1406 .debug_sup section.
1407
1408 2021-04-29 Nick Clifton <nickc@redhat.com>
1409
1410 PR 27594
1411 * doc/binutils.texi (windres): Correct the description of the
1412 default value of the --preprocessor argument.
1413
1414 2021-04-27 Nick Clifton <nickc@redhat.com>
1415
1416 PR 27779
1417 * dwarf.c (parse_gnu_debuglink): Reject empty names.
1418 (parse_gnu_debugaltlink): Likewise.
1419
1420 2021-04-22 Clément Chigot <clement.chigot@atos.net>
1421
1422 * od-xcoff.c (dump_xcoff32_symbols): Adapt to new
1423 aux structures.
1424
1425 2021-04-21 Nick Lott <nick.lott@gmail.com>
1426
1427 PR 27672
1428 * readelf.c (sym_base): New variable.
1429 (enum print_mode): Add more modes.
1430 (print_vma): Add suport for new modes.
1431 (options): Add sym-base.
1432 (usage): Add sym-base.
1433 (parse_args): Add support for --sym-base.
1434 (print_dynamic_symbol_size): New function.
1435 (print_dynamic_symbol): Use new function.
1436 * doc/binutils.texi: Document the new feature.
1437 * NEWS: Mention the new feature.
1438
1439 2021-04-21 Nick Clifton <nickc@redhat.com>
1440
1441 * testsuite/binutils-all/mips/global-local-symtab-sort-n64t.d:
1442 Adjust expected output to allow for named section symbols.
1443 * testsuite/binutils-all/mips/global-local-symtab-sort-o32t.d:
1444 Likewise.
1445 * testsuite/binutils-all/readelf.s-64: Likewise.
1446 * testsuite/binutils-all/readelf.ss-64-unused: Likewise.
1447 * testsuite/binutils-all/readelf.ss-tmips: Likewise.
1448 * testsuite/binutils-all/readelf.ss-unused: Likewise.
1449
1450 2021-04-21 Luo Longjun <luolongjun@huawei.com>
1451
1452 * readelf.c (print_dynamic_symbol): Print the section name for
1453 section symbols without a name of their own.
1454
1455 2021-04-20 Andreas Krebbel <krebbel@linux.ibm.com>
1456
1457 * MAINTAINERS: Remove Martin Schwidefsky as s390 maintainer and
1458 add him to Past Maintainers.
1459 Update my email address.
1460
1461 2021-04-19 Nick Clifton <nickc@redhat.com>
1462
1463 PR 21702
1464 * arsup.c (ar_addmod): Enable plugin support, if available.
1465
1466 2021-04-19 Nick Clifton <nickc@redhat.com>
1467
1468 * rename.c: (get_stat_atime_ns): Add prototype.
1469 (get_stat_mtime_ns): Add prototype.
1470
1471 2021-04-16 Alan Modra <amodra@gmail.com>
1472
1473 PR 27725
1474 * rename.c (get_stat_atime, get_stat_mtime): Make static.
1475 (get_stat_atime_ns, get_stat_mtime_ns): Likewise.
1476
1477 2021-04-15 Pekka Seppänen <pexu@sourceware.mail.kapsi.fi>
1478
1479 PR 27725
1480 * rename.c (get_stat_atime_ns): Add ATTRIBUTE_UNUSED.
1481 (get_stat_mtime_ns): Likewise.
1482
1483 2021-04-15 Alan Modra <amodra@gmail.com>
1484
1485 PR 27725
1486 * configure.ac: Check for sys/time.h and utimensat. Use standard
1487 checks for mkstemp and mkdtemp. Whitespace. Check for nanosecond
1488 members of struct stat.
1489 * rename.c: Prefer sys/time.h for utimes over utime.h for utime.
1490 (STAT_TIMESPEC, STAT_TIMESPEC_NS): Define
1491 (get_stat_atime_ns, get_stat_mtime_ns): New inline functions.
1492 (get_stat_atime, get_stat_mtime): Likewise.
1493 (set_times): Choose first available of utimensat, utimes, utime.
1494 Use above inline functions to set timespec and timeval values.
1495 * configure: Regenerate.
1496 * config.in: Regenerate.
1497 * testsuite/binutils-all/objcopy.exp (objcopy_test): Add test of
1498 file timestamp when --preserve-dates is used.
1499
1500 2021-04-15 Alan Modra <amodra@gmail.com>
1501
1502 PR 27456
1503 * rename.c (smart_rename): When TO and FROM are equal, just set
1504 file timestamp.
1505 * objcopy.c (strip_main, copy_main): Always call smart_rename.
1506
1507 2021-04-14 H.J. Lu <hongjiu.lu@intel.com>
1508
1509 PR binutils/27708
1510 * testsuite/binutils-all/x86-64/pr27708.dump: New file.
1511 * testsuite/binutils-all/x86-64/pr27708.exe.bz2: Likewise.
1512 * testsuite/binutils-all/x86-64/x86-64.exp: Run binutils/27708
1513 test.
1514
1515 2021-04-14 Mark Harmstone <mark@harmstone.com>
1516
1517 PR 27686
1518 * resbin.c (bin_to_res_version): Ignore any trailing bytes at the
1519 end of the structure.
1520
1521 2021-04-14 Frederic Cambus <fred@statdns.com>
1522
1523 * readelf.c (get_netbsd_elfcore_note_type): Remove unneeded #ifdef
1524 checks for NT_NETBSDCORE_AUXV and NT_NETBSDCORE_LWPSTATUS.
1525
1526 2021-04-14 Alan Modra <amodra@gmail.com>
1527
1528 PR 27716
1529 * objdump.c (show_line): Don't limit paths to PATH_MAX.
1530 * readelf.c (struct filedata): Change program_interpreter from
1531 a char array to a char pointer.
1532 (process_program_headers): Sanity check PT_INTERP p_filesz.
1533 Malloc program_interpreter using p_filesz and read directly from
1534 file.
1535 (process_dynamic_section): Check program_interpreter is non-NULL.
1536 (free_filedata): New function, split out from..
1537 (process_object): ..here.
1538 (close_debug_file): Call free_filedata.
1539 * sysdep.h: Don't include sys/param.h.
1540 (PATH_MAX): Don't define.
1541 * configure.ac: Don't check for sys/param.h.
1542 * configure: Regenerate.
1543
1544 2021-04-13 Frederic Cambus <fred@statdns.com>
1545
1546 * readelf.c (process_netbsd_elf_note): Remove now unneeded #ifdef
1547 check for NT_NETBSD_PAX.
1548
1549 2021-04-12 Alan Modra <amodra@gmail.com>
1550
1551 * configure.ac (--enable-checking): Add support.
1552 * config.in: Regenerate.
1553 * configure: Regenerate.
1554
1555 2021-04-09 Alan Modra <amodra@gmail.com>
1556
1557 * objdump.c (struct objdump_disasm_info): Delete dynrelbuf and
1558 dynrelcount.
1559 (find_symbol_for_address): Adjust for dynrelbuf and dynrelcount move.
1560 (disassemble_section, disassemble_data): Likewise.
1561
1562 2021-04-06 Alan Modra <amodra@gmail.com>
1563
1564 * objdump.c (objdump_symbol_at_address): Return asymbol*.
1565
1566 2021-04-06 Alan Modra <amodra@gmail.com>
1567
1568 * NEWS: Mention C99 requirement.
1569 * README: Likewise. Modernise examples and "Reporting bugs".
1570
1571 2021-04-05 Alan Modra <amodra@gmail.com>
1572
1573 * configure.ac: Assume long long is available. Don't test for
1574 strings.h, stdlib.h, limits.h, locale.h, or wchar.h. Check
1575 inttypes.h, stdint.h, sys/stat.h and sys/types.h. Don't check for
1576 strcoll, setlocale, setmode or location of time_t. Don't check
1577 for fprintf, getenv, snprintf, strnlen, strstr or vsnprintf decls.
1578 (AC_ISC_POSIX, AXC_HEADER_STRING, AC_FUNC_ALLOCA): Don't invoke.
1579 * sysdep.h: Don't include alloca-conf.h, include config.h instead.
1580 Test HAVE_SYS_TYPES_H and reorder includes. Include limits.h,
1581 locale.h, string.h and stdlib.h unconditionally. Remove various
1582 fallback declarations. Assume long long is available.
1583 * addr2line.c: Don't test HAVE_SETLOCALE.
1584 * ar.c: Likewise.
1585 * coffdump.c: Likewise.
1586 * dlltool.c: Likewise.
1587 * dllwrap.c: Likewise.
1588 * elfedit.c: Likewise.
1589 * nm.c: Likewise.
1590 * objcopy.c: Likewise.
1591 * objdump.c: Likewise.
1592 * readelf.c: Likewise.
1593 * size.c: Likewise.
1594 * srconv.c: Likewise.
1595 * strings.c: Likewise.
1596 * sysdump.c: Likewise.
1597 * windmc.c: Likewise.
1598 * windres.c: Likewise.
1599 * bucomm.c: Don't test HAVE_TIME_T_IN_TIME_H or HAVE_TIME_T_IN_TYPES_H.
1600 * dwarf.c: Include limits.h unconditionally. Assume long long
1601 is available.
1602 * nm.c: Don't test HAVE_STRCOLL.
1603 * readelf.c: Don't test HAVE_WCHAR_H.
1604 * strings.c: Assume long long is available.
1605 * syslex.l: Include string.h unconditionally.
1606 * aclocal.m4: Regenerate.
1607 * config.in: Regenerate.
1608 * configure: Regenerate.
1609 * Makefile.in: Regenerate.
1610 * doc/Makefile.in: Regenerate.
1611
1612 2021-04-01 Martin Liska <mliska@suse.cz>
1613
1614 * elfcomm.h (strneq): Remove strneq and use startswith.
1615 * readelf.c (ia64_process_unwind): Likewise.
1616 (process_note): Likewise.
1617
1618 2021-04-01 Martin Liska <mliska@suse.cz>
1619
1620 * dllwrap.c: Use startswith function.
1621 * objcopy.c (is_dwo_section): Likewise.
1622 (handle_remove_section_option): Likewise.
1623 (copy_main): Likewise.
1624 * objdump.c (is_significant_symbol_name): Likewise.
1625
1626 2021-04-01 Martin Liska <mliska@suse.cz>
1627
1628 * dwarf.c (display_debug_lines_raw): Replace const_strneq with
1629 startswith.
1630 (display_debug_lines_decoded): Likewise.
1631 (display_debug_links): Likewise.
1632 * elfcomm.c (setup_archive): Likewise.
1633 * elfcomm.h (const_strneq): Likewise.
1634 * readelf.c (process_section_headers): Likewise.
1635 (slurp_ia64_unwind_table): Likewise.
1636 (slurp_hppa_unwind_table): Likewise.
1637 (decode_arm_unwind): Likewise.
1638 (display_debug_section): Likewise.
1639 (process_note): Likewise.
1640
1641 2021-03-31 Alan Modra <amodra@gmail.com>
1642
1643 * sysdep.h (POISON_BFD_BOOLEAN): Define.
1644 * addr2line.c, * ar.c, * arsup.c, * bfdtest2.c, * binemul.c,
1645 * binemul.h, * bucomm.c, * bucomm.h, * budbg.h, * coffgrok.c,
1646 * debug.c, * debug.h, * dlltool.c, * dwarf.c, * dwarf.h,
1647 * elfedit.c, * emul_aix.c, * mclex.c, * nm.c, * objcopy.c,
1648 * objdump.c, * od-macho.c, * prdbg.c, * rdcoff.c, * rddbg.c,
1649 * readelf.c, * rename.c, * stabs.c, * strings.c, * windint.h,
1650 * windmc.c, * windmc.h, * windres.c, * winduni.c,
1651 * wrstabs.c: Replace bfd_boolean with bool, FALSE with false,
1652 and TRUE with true throughout.
1653
1654 2021-03-31 Alan Modra <amodra@gmail.com>
1655
1656 * coffdump.c: Include stdint.h in place of bfd_stdint.h.
1657 * dwarf.c: Likewise.
1658
1659 2021-03-31 Alan Modra <amodra@gmail.com>
1660
1661 * prdbg.c (pr_function_type): Replace LITSTTCPY with strcpy.
1662
1663 2021-03-29 Alan Modra <amodra@gmail.com>
1664
1665 * dlltool.c (main): Don't use "boolean_condition ? TRUE : FALSE".
1666 * dwarf.c (read_and_display_attr_value): Likewise.
1667 (display_debug_str_offsets): Likewise.
1668 * objdump.c (dump_bfd): Likewise.
1669 * readelf.c (dump_section_as_strings): Likewise.
1670 (dump_section_as_bytes): Likewise.
1671
1672 2021-03-29 Alan Modra <amodra@gmail.com>
1673
1674 * objdump.c (process_links): Use type int.
1675 * readelf.c (request_dump): Don't increment do_dump, set it.
1676 * windint.h (target_is_bigendian): Use type bfd_boolean.
1677 * windmc.c (target_is_bigendian): Likewise.
1678 * windres.c (target_is_bigendian): Likewise.
1679
1680 2021-03-22 Martin Liska <mliska@suse.cz>
1681
1682 * dlltool.c (scan_drectve_symbols): Replace usage of CONST_STRNEQ
1683 with startswith.
1684 * emul_aix.c (ar_emul_aix_parse_arg): Likewise.
1685 * objcopy.c (is_mergeable_note_section): Likewise.
1686 * objdump.c (dump_dwarf_section): Likewise.
1687 * prdbg.c (pr_method_type): Likewise.
1688 (pr_class_baseclass): Likewise.
1689 (tg_class_baseclass): Likewise.
1690 * readelf.c (process_lto_symbol_tables): Likewise.
1691 * stabs.c (ULLHIGH): Likewise.
1692 (parse_stab_argtypes): Likewise.
1693 (stab_demangle_function_name): Likewise.
1694
1695 2021-03-19 H.J. Lu <hongjiu.lu@intel.com>
1696
1697 * readelf.c (get_machine_name): Add EM_INTELGT.
1698
1699 2021-03-18 Nick Clifton <nickc@redhat.com>
1700
1701 PR 27478
1702 * readelf.c (dump_section_as_strings): Mention separate filename.
1703 (dump_section_as_bytes): Likewise.
1704 (dump_section_as_ctf): Likewise.
1705 (initialise_dumkps_byname): Only issue a warning for missing
1706 sections if processing the main file.
1707 (process_section_contents): Only issue a warning for unsumped
1708 section numbers in the main file.
1709 (initialise_dump_sects): New function. Contains code extracted
1710 from ...
1711 (process_object): ... here. Also call initialise_dump_sects for
1712 separate files.
1713
1714 2021-03-16 Nick Clifton <nickc@redhat.com>
1715
1716 PR 27534
1717 * readelf.c (display_debug_section): Also retain .debug_addr
1718 sections.
1719
1720 2021-03-16 Nick Clifton <nickc@redhat.com>
1721
1722 PR 27533
1723 * readelf.c (process_section_contents): Only dump debug
1724 information for separate files unless process_links is enabled.
1725 (process_object): Always call process_section_contents for
1726 separate info files.
1727
1728 2021-03-15 Nick Clifton <nickc@redhat.com>
1729
1730 PR 27487
1731 * nm.c (FORMAT_JUST_SYMBOLS): Define.
1732 (struct optput_fns): Add entry for FORMAT_JUST_SYMBOLS.
1733 (long_options): Add just-symbols.
1734 (set_output_format): Add support for just-symbols.
1735 (get_print_format): Likewise.
1736 (do_not_print_object_filename): New function.
1737 (do_not_print_archive_filename): New function.
1738 (do_not_print_archive_member): New function.
1739 (do_not_print_symbol_filename): New function.
1740 (just_print_symbol_name): New function.
1741 (main): Handle --just-symbols.
1742 * NEWS: Mention the new feature.
1743 * doc/binutils.texi: Document the new feature.
1744
1745 2021-03-12 Clément Chigot <clement.chigot@atos.net>
1746
1747 * od-xcoff.c: Replace RTB by TRL entry.
1748
1749 2021-03-05 Craig Blackmore <craig.blackmore@embecosm.com>
1750 Andrew Burgess <andrew.burgess@embecosm.com>
1751
1752 * readelf.c (get_note_type): Handle NT_RISCV_CSR.
1753
1754 2021-03-05 Craig Blackmore <craig.blackmore@embecosm.com>
1755 Andrew Burgess <andrew.burgess@embecosm.com>
1756
1757 * readelf.c (get_note_type): Handle NT_GDB_TDESC.
1758
1759 2021-03-05 Nick Clifton <nickc@redhat.com>
1760
1761 PR 27387
1762 * dwarf.c (display_debug_macro): Handle the displaying of
1763 DW_MACRO_define_strp and DW_MACRO_undef_strp in v4
1764 .debug_macro.dwo sections.
1765
1766 2021-03-04 Nick Clifton <nickc@redhat.com>
1767
1768 PR 27478
1769 * objdump.c (process_links): New variable.
1770 (usage): Add --process-links.
1771 (long_options): Likewise.
1772 (dump_bfd): Stop processing once the bfd has been loaded unless
1773 this is the main file or process_links has been enabled.
1774 (main): Handle the process-links option.
1775 * readelf.c (process_links): New variable.
1776 (struct filedata): Add is_separate field.
1777 (options): Add --process-links.
1778 (usage): Likewise.
1779 (parse_args): Likewise.
1780 (process_file_header): Include the filename when dumping
1781 information for separate debuginfo files.
1782 (process_program_headers): Likewise.
1783 (process_section_headers): Likewise.
1784 (process_section_groups): Likewise.
1785 (process_relocs): Likewise.
1786 (process_dynamic_section): Likewise.
1787 (process_version_sections): Likewise.
1788 (display_lto_symtab): Likewise.
1789 (process_symbol_table): Likewise.
1790 (process_syminfo): Likewise.
1791 (initialise_dumps_by_name): Likewise.
1792 (process_section_contents): Likewise.
1793 (process_notes_at): Likewise.
1794 (process_notes): Likewise.
1795 (open_file): Add is_separate parameter. Use to initialise the
1796 is_separate field in the filedata structure.
1797 (open_deug): Update call to open_file.
1798 (process_object): Add processing of the contents of separate
1799 debuginfo files, gated by the process_links variable.
1800 (process_archive): Update call to open_file.
1801 (process_file): Initialise the is_separate field in the filedata
1802 structure.
1803 * dwarf.c (load_separate_debug_info_file): Only report the
1804 loading of a separate file if debug links are being dumped.
1805 * objcopy.c (keep_section_symbols): New variable.
1806 (enum command_line_switch): Add OPTION_KEEP_SYMBOLS.
1807 (strip_options): Add keep-section-symbols.
1808 (copy_options): Likewise.
1809 (copy_usage): Likewise.
1810 (strip_usage): Likewise.
1811 (copy_object): Keep section symbols if requested by command line
1812 option.
1813 (strip_main): Handle --keep-section-symbols.
1814 (copy_main): Likewise.
1815 * doc/binutils.texi: Document the new options.
1816 * NEWS: Mention the new features.
1817 * testsuite/binutils-all/compress.exp (test_gnu_debuglink):
1818 Update options passed to objdump. Use diff rather than cmp to
1819 compare the dumped data.
1820 * testsuite/binutils-all/objdump.WK2: Update regexp.
1821 * testsuite/binutils-all/objdump.WK3: Update regexp.
1822 * testsuite/binutils-all/objdump.exp: Use --process-links
1823 instead of --dwarf=follow-links.
1824 * testsuite/binutils-all/readelf.exp (readelf_test): Include
1825 readelf's output in the log when the test fails.
1826 Add the -P option to the -wKis test.
1827 * testsuite/binutils-all/readelf.wKis: Update expected output.
1828
1829 2021-03-03 Alan Modra <amodra@gmail.com>
1830
1831 PR 27493
1832 * objcopy.c (filter_symbols): Apply --weaken to undefined symbols.
1833 * NEWS: Mention feature.
1834
1835 2021-03-01 H.J. Lu <hongjiu.lu@intel.com>
1836
1837 PR binutils/27486
1838 * dwarf.c (load_separate_debug_info): Issue warning only if
1839 do_debug_links is set.
1840 * testsuite/binutils-all/compress.exp: Run objdump and readelf
1841 with missing debug file.
1842
1843 2021-03-01 Alan Modra <amodra@gmail.com>
1844
1845 PR 27128
1846 * doc/binutils.texi: Add nm --with-symbol-versions and
1847 --without-symbol-versions documentation.
1848 * nm.c (with_symbol_versions): New variable.
1849 (enum long_option_values): Delete OPTION_WITH_SYMBOL_VERSIONS.
1850 (long_options): Make --with-symbol-versions entry twiddle the flag.
1851 Add --without-symbol-versions.
1852 (print_symname): Strip version when !with_symbol_versions. Add
1853 dynamic version info under control of with_symbol_versions.
1854 (main): Remove OPTION_WITH_SYMBOL_VERSIONS case.
1855
1856 2021-02-26 Fangrui Song <maskray@google.com>
1857
1858 PR 27408
1859 * readelf.c (quiet): New option flag.
1860 (enum long_option_values): New enum to hold long option value.
1861 (long_options): Add --quiet.
1862 (usage): Mention --quiet.
1863 (display_rel_file): If quiet is enabled, suppress "no symbols".
1864 (main): Handle the new option.
1865 * NEWS: Mention --quiet.
1866 * docs/binutils.texi: Document --quiet.
1867
1868 2021-02-26 Tom de Vries <tdevries@suse.de>
1869
1870 * dwarf.c (display_debug_addr): Handle dwarf-5 .debug_addr bits.
1871
1872 2021-02-26 Tom de Vries <tdevries@suse.de>
1873
1874 PR 27390
1875 * dwarf.c: (skip_attr_bytes): Add support for DW_FORM_str* and
1876 DW_FORM_addrx*.
1877 (read_and_display_attr_value): Likewise.
1878
1879 2021-02-25 Nick Clifton <nickc@redhat.com>
1880
1881 * dwarf.c (get_type_abbrev_from_form): Accept but ignore sup
1882 forms.
1883 (read_and_display_attr_value): Handle sup forms.
1884 (display_debug_sup): New function. Displays the contents of a
1885 .debug_sup section.
1886 (load_debug_sup_file): New function. Loads the contents of a file
1887 referenced by a .debug_sup section.
1888 (check_for_and_load_links): Call load_debug_sup_file.
1889 (debug_displays): Add entry for .debug_sup.
1890 * dwarf.h (enum dwarf_section_display_enum): Add debug_sup.
1891 * readelf.c (process_section_headers): Add support for debug_sup.
1892 * doc/debug.options.texi: Note that the =links option will display
1893 the contents of .debug_sup sections.
1894 * NEWS: Mention the new support.
1895
1896 2021-02-25 Alan Modra <amodra@gmail.com>
1897
1898 PR 27456
1899 * rename.c (simple_copy): Mark target_stat ATTRIBUTE_UNUSED.
1900
1901 2021-02-24 Nick Clifton <nickc@redhat.com>
1902
1903 PR 27285
1904 * od-elf32_avr.c (elf32_avr_get_memory_usage): Check for overflows
1905 when adding together the section sizes.
1906
1907 2021-02-24 Nick Clifton <nickc@redhat.com>
1908
1909 * objcopy.c (merge_gnu_build_notes): Remove support for v1/v2 GNU
1910 build notes.
1911 * readelf.c (print_gnu_build_attribute_description): Likewise.
1912
1913 2021-02-24 Alan Modra <amodra@gmail.com>
1914 Siddhesh Poyarekar <siddhesh@gotplt.org>
1915
1916 PR 27456
1917 * bucomm.h (smart_rename): Update prototype.
1918 * rename.c (smart_rename): Add fromfd and preserve_dates params.
1919 Pass fromfd and target_stat to simple_copy. Call set_times
1920 when preserve_dates.
1921 (simple_copy): Accept fromfd rather than from filename. Add
1922 target_stat param. Rewind fromfd rather than opening. Open
1923 "to" file without O_CREAT. Try to preserve S_ISUID and S_ISGID.
1924 * ar.c (write_archive): Rename ofd to tmpfd. Dup tmpfd before
1925 closing output temp file, and pass tmpfd to smart_rename.
1926 * arsup.c (temp_fd): Rename from real_fd.
1927 (ar_save): Dup temp_fd and pass to smart_rename.
1928 * objcopy.c (strip_main, copy_main): Likewise, and pass
1929 preserve_dates.
1930
1931 2021-02-24 Alan Modra <amodra@gmail.com>
1932
1933 PR 27456
1934 * rename.c: Tidy throughout.
1935 (smart_rename): Always copy. Remove windows specific code.
1936
1937 2021-02-20 Alan Modra <amodra@gmail.com>
1938
1939 * testsuite/lib/binutils-common.exp: Whitespace fixes throughout.
1940 (run_dump_test): Fail if expecting errors from a file like we do
1941 for error strings, if no error is seen.
1942
1943 2021-02-19 Alan Modra <amodra@gmail.com>
1944
1945 * testsuite/binutils-all/readelf.exp (pr26548): Run for 32-bit too.
1946
1947 2021-02-19 Siddhesh Poyarekar <siddhesh@gotplt.org>
1948
1949 * ar.c (write_archive): Remove TARGET_STAT. Adjust call to
1950 SMART_RENAME.
1951 * arsup.c (ar_save): Likewise.
1952 * objcopy (strip_main): Don't copy TMPFD. Don't set times on
1953 temporary file and adjust call to SMART_RENAME.
1954 (copy_main): Likewise.
1955 * rename.c [!S_ISLNK]: Remove definitions.
1956 (try_preserve_permissions): Remove function.
1957 (smart_rename): Remove FD, PRESERVE_DATES arguments. Use
1958 rename system call only if TO does not exist.
1959 * bucomm.h (smart_rename): Adjust declaration.
1960
1961 2021-02-18 Nick Clifton <nickc@redhat.com>
1962
1963 * objcopy.c (merge_gnu_build_notes): Handle notes with a start
1964 address that is higher than the end address.
1965
1966 2021-02-17 Alan Modra <amodra@gmail.com>
1967
1968 * dwarf.c: Include limits.h.
1969 (CHAR_BIT): Provide backup define.
1970 (read_leb128): Use CHAR_BIT to size "result" in bits. Correct
1971 signed overflow checking.
1972 * testsuite/binutils-all/pr26548.s,
1973 * testsuite/binutils-all/pr26548.d,
1974 * testsuite/binutils-all/pr26548e.d: New tests.
1975 * testsuite/binutils-all/readelf.exp: Run them.
1976 (readelf_test): Drop unused "xfails" parameter. Update all uses.
1977
1978 2021-02-16 Jan Beulich <jbeulich@suse.com>
1979
1980 * dwarf.c (process_debug_info): Initialize "dwo_id".
1981
1982 2021-02-15 Alan Modra <amodra@gmail.com>
1983
1984 * objdump.c (load_specific_debug_section): Don't call
1985 bfd_cache_section_contents. Rearrange so that
1986 bfd_get_full_section_contents is not called on path where
1987 bfd_simple_get_relocated_section_contents is called.
1988 Don't set section->user_data.
1989 (free_debug_section): Always free section->start. Don't twiddle
1990 section flags.
1991 * readelf.c (load_specific_debug_section): Don't set user_data.
1992 * dwarf.h (struct dwarf_section): Remove use_data field.
1993 * dwarf.c (NO_ABBREVS, ABBREV): Adjust to suit.
1994
1995 2021-02-15 Alan Modra <amodra@gmail.com>
1996
1997 * testsuite/binutils-all/compress.exp: Remove nds32 xfails.
1998 * testsuite/binutils-all/objdump.exp: Likewise.
1999
2000 2021-02-14 Alan Modra <amodra@gmail.com>
2001
2002 * objdump.c (slurp_symtab): Don't add an extra entry for NULL
2003 to the symbol array.
2004 (slurp_dynamic_symtab): Likewise.
2005 (dump_bfd): Formatting. Copy terminating NULL from extra_syms.
2006
2007 2021-02-14 Alan Modra <amodra@gmail.com>
2008
2009 * Makefile.in: Regenerate.
2010 * doc/Makefile.in: Regenerate.
2011
2012 2021-02-13 Mike Frysinger <vapier@gentoo.org>
2013
2014 * aclocal.m4: Regenerate.
2015
2016 2021-02-12 Nick Clifton <nickc@redhat.com>
2017
2018 * configure.ac (follow-debug-links): Add option to enable or
2019 disable the following of debug links by default. Set the
2020 default for the option to be 'follow'.
2021 * dwarf.c (do_follow_links): Initialise with DEFAULT_FOR_FOLLOW_LINKS.
2022 (dwarf_select_sections_by_names): Add no-follow-links option.
2023 (dwarf_select_sections_by_letter): Add 'N' option.
2024 * objdump.c (usage): Add conditional text describing the
2025 follow links option.
2026 (slurp_symtab): Ensure that there is a NULL entry at the end
2027 of the symbol table.
2028 (slurp_dynamic_symtab): Likewise.
2029 (dump_bfd): When extending the symbol table, ensure that there
2030 is still a NULL entry at the end.
2031 * readelf.c (usage): Add conditional text describing the
2032 follow links option.
2033 * doc/binutils.texi: Update documentation for objcopy and
2034 readelf.
2035 * doc/debug.options.texi: Update documentation of the
2036 follow-links option.
2037 * config.in: Regenerate.
2038 * configure: Regenerate.
2039 * testsuite/binutils-all/compress.exp: Add the -WN option to
2040 objdump command lines that are not expecting to follow links.
2041 * testsuite/binutils-all/readelf.exp: Add the
2042 --debug-dump=no-follow-links option to tests that are not
2043 expecting to follow debug links.
2044 * NEWS: Mention the new behaviour.
2045
2046 2021-02-12 Alan Modra <amodra@gmail.com>
2047
2048 * testsuite/binutils-all/objcopy.exp: Report "unsupported" when
2049 gas or ld fails to build a testcase rather than "unresolved".
2050 Report "fail" when readelf returns an error status rather than
2051 "unresolved".
2052 * testsuite/binutils-all/ar.exp: Likewise.
2053 * testsuite/binutils-all/compress.exp: Likewise.
2054 * testsuite/binutils-all/readelf.exp: Likewise.
2055
2056 2021-02-12 Alan Modra <amodra@gmail.com>
2057
2058 * testsuite/binutils-all/pr25662.s: Replace "a" with "aaa" and
2059 "c" with "ccc" labels.
2060
2061 2021-02-12 Tom de Vries <tdevries@suse.de>
2062
2063 * dwarf.h (debug_info): Fix typo in comment.
2064
2065 2021-02-12 Tom de Vries <tdevries@suse.de>
2066
2067 * dwarf.c (display_debug_str_offsets): Handle multiple sets of
2068 entries.
2069
2070 2021-02-12 Tom de Vries <tdevries@suse.de>
2071
2072 * dwarf.c (process_debug_info): Print DWO ID.
2073
2074 2021-02-11 Alan Modra <amodra@gmail.com>
2075
2076 PR 27290
2077 PR 27293
2078 PR 27295
2079 * od-elf32_avr.c (elf32_avr_get_note_section_contents): Formatting.
2080 Use bfd_malloc_and_get_section.
2081 (elf32_avr_get_note_desc): Formatting. Return descsz. Sanity
2082 check namesz. Return NULL if descsz is too small. Ensure
2083 string table is terminated.
2084 (elf32_avr_get_device_info): Formatting. Add note_size param.
2085 Sanity check note.
2086 (elf32_avr_dump_mem_usage): Adjust to suit.
2087
2088 2021-02-10 Tom de Vries <tdevries@suse.de>
2089
2090 PR binutils/27391
2091 * dwarf.c (load_dwo_file): Handle case that name is absolute path.
2092
2093 2021-02-10 Tom de Vries <tdevries@suse.de>
2094
2095 PR binutils/27371
2096 * dwarf.c (display_debug_ranges): Filter range lists according to
2097 section.
2098
2099 2021-02-09 Tom de Vries <tdevries@suse.de>
2100
2101 PR binutils/27370
2102 * dwarf.c (get_type_abbrev_from_form): Handle DW_FORM_ref_sig8.
2103
2104 2021-02-09 Tom de Vries <tdevries@suse.de>
2105
2106 PR binutils/27386
2107 * dwarf.c (process_debug_info): Handling DW_UT_skeleton and
2108 DW_UT_split_compile.
2109
2110 2021-02-09 Alan Modra <amodra@gmail.com>
2111
2112 * testsuite/lib/binutils-common.exp (supports_gnu_osabi): Remove
2113 symbianelf.
2114
2115 2021-02-07 Alan Modra <amodra@gmail.com>
2116
2117 * unwind-ia64.c (unw_print_xyreg): Don't leave output buffer
2118 uninitialised on invalid input.
2119
2120 2021-02-06 Alan Modra <amodra@gmail.com>
2121
2122 PR 27349
2123 * rename.c (smart_rename): Test for existence and type of output
2124 file with lstat.
2125
2126 2021-02-05 Nick Clifton <nickc@redhat.com>
2127
2128 * MAINTAINERS: Remove Richard Henderson as the ALPHA maintainer.
2129
2130 2021-02-05 Eli Zaretskii <eliz@gnu.org>
2131
2132 PR 27252
2133 * elfedit.c (check_file):
2134 * bucomm.c (get_file_size): Fix typos in comments.
2135
2136 2021-02-05 Alan Modra <amodra@gmail.com>
2137
2138 PR 27345
2139 * arsup.c (ar_save): Use stat rather than lstat.
2140
2141 2021-02-03 Alan Modra <amodra@gmail.com>
2142
2143 PR 27270
2144 PR 27284
2145 PR 26945
2146 * ar.c: Don't include libbfd.h.
2147 (write_archive): Replace xmalloc+strcpy with xstrdup. Use
2148 bfd_stat rather than fstat on iostream. Move stat and fd tests
2149 outside of _WIN32 ifdef. Delete skip_stat variable.
2150 * arsup.c (temp_name, real_ofd): New static variables.
2151 (ar_open): Use make_tempname and bfd_fdopenw.
2152 (ar_save): Adjust to suit ar_open changes. Move stat output
2153 of _WIN32 ifdef.
2154 * objcopy.c: Don't include libbfd.h.
2155 (copy_file): Use bfd_stat.
2156
2157 2021-02-02 H.J. Lu <hongjiu.lu@intel.com>
2158
2159 PR binutils/27281
2160 * readelf.c (process_section_headers): Add 'R' and 'D' to
2161 "Key to Flags:".
2162 * testsuite/binutils-all/retain1a.d: Updated.
2163
2164 2021-01-30 Nick Clifton <nickc@redhat.com>
2165
2166 * README-how-to-make-a-release: Small updates after the 2.35.2
2167 release.
2168
2169 2021-01-28 Eli Zaretskii <eliz@gnu.org>
2170
2171 PR 4356
2172 * windres.c (quot): Use double quotes to protect strings on
2173 Windows platforms.
2174
2175 2021-01-28 Eli Zaretskii <eliz@gnu.org>
2176
2177 PR 27252
2178 * bucomm.c (get_file_size): Add code to handle /dev/null on
2179 Windows systems.
2180 * elfedit.c (check_file): Likewise.
2181
2182 2021-01-27 Nick Clifton <nickc@redhat.com>
2183
2184 * objcopy.c (copy_main): Remove conditional control of the calls
2185 to free, simplifying the code and making it easier to detect
2186 typos.
2187
2188 2021-01-26 Frederic Cambus <fred@statdns.com>
2189
2190 * objcopy.c (copy_main): Fix a double free happening when both
2191 --localize-symbols and --globalize-symbols options are invoked
2192 together.
2193
2194 2021-01-24 Nick Clifton <nickc@redhat.com>
2195
2196 * README-how-to-make-a-release: Minor updates after the 2.36 release.
2197
2198 2021-01-16 Alan Modra <amodra@gmail.com>
2199
2200 * readelf.c (uncompress_section_contents): Tidy inflateEnd result test.
2201
2202 2021-01-15 Alan Modra <amodra@gmail.com>
2203
2204 PR 26539
2205 * readelf.c (uncompress_section_contents): Always call inflateEnd.
2206
2207 2021-01-14 Alexandre Oliva <oliva@gnu.org>
2208
2209 * MAINTAINERS: Update my email address.
2210
2211 2021-01-14 Nick Clifton <nickc@redhat.com>
2212
2213 * po/sv.po: Updated Swedish translation.
2214
2215 2021-01-13 Alan Modra <amodra@gmail.com>
2216
2217 * Makefile.in: Regenerate.
2218 * doc/Makefile.in: Regenerate.
2219
2220 2021-01-13 Zebediah Figura <z.figura12@gmail.com>
2221
2222 PR 27037
2223 * dlltool.c (i386_trampoline): Adjust %rsp immediately on entry
2224 and before exit.
2225 (i386_x64_trampoline): Add SEH annotations.
2226 (struct mac): Add how_seh field.
2227 (make_delay_head): If how_set field is true add SEh instructions.
2228
2229 2021-01-12 H.J. Lu <hongjiu.lu@intel.com>
2230
2231 PR binutils/26792
2232 * configure.ac: Use GNU_MAKE_JOBSERVER.
2233 * aclocal.m4: Regenerated.
2234 * configure: Likewise.
2235
2236 2021-01-12 Nick Clifton <nickc@redhat.com>
2237
2238 * po/fr.po: Updated French translation.
2239
2240 2021-01-11 H.J. Lu <hongjiu.lu@intel.com>
2241
2242 PR ld/27173
2243 * configure: Regenerated.
2244
2245 2021-01-11 Nick Clifton <nickc@redhat.com>
2246
2247 * po/pt.po: Updated Portuguese translation.
2248 * po/sr.po: Updated Serbian translation.
2249 * po/uk.po: Updated Ukranian translation.
2250
2251 2021-01-09 H.J. Lu <hongjiu.lu@intel.com>
2252
2253 * configure: Regenerated.
2254
2255 2021-01-09 Nick Clifton <nickc@redhat.com>
2256
2257 * configure: Regenerate.
2258 * po/binutils.pot: Regenerate.
2259
2260 2021-01-09 Nick Clifton <nickc@redhat.com>
2261
2262 * 2.36 release branch crated.
2263 * README-how-to-make-a-release: Add note about updating Makefiles
2264 and libtool files.
2265 * BRANCHES: Add binutils-2.36-branch.
2266
2267 2021-01-09 Alan Modra <amodra@gmail.com>
2268
2269 * configure: Regenerate.
2270
2271 2021-01-07 Samuel Thibault <samuel.thibault@gnu.org>
2272
2273 * configure: Regenerate.
2274
2275 2021-01-07 H.J. Lu <hongjiu.lu@intel.com>
2276
2277 PR 27109
2278 * objcopy.c (copy_object): Handle section symbols for
2279 non-relocatable inputs.
2280 * testsuite/binutils-all/readelf.exp (readelf_test): Check
2281 is_elf_unused_section_symbols.
2282 * testsuite/binutils-all/readelf.s-64: Updated.
2283 * testsuite/binutils-all/readelf.ss: Likewise.
2284 * testsuite/binutils-all/readelf.ss-64: Likewise.
2285 * testsuite/binutils-all/readelf.s-64-unused: New file.
2286 * testsuite/binutils-all/readelf.ss-64-unused: Likewise.
2287 * testsuite/binutils-all/readelf.ss-unused: Likewise.
2288 * testsuite/lib/binutils-common.exp
2289 (is_elf_unused_section_symbols): New proc.
2290
2291 2021-01-06 Reuben Thomas <rrt@sc3d.org>
2292
2293 * binutils/readelf.c: Correct grammar in comment.
2294
2295 2021-01-01 Nicolas Boulenguez <nicolas@debian.org>
2296
2297 * coffgrok.c (do_type): Correct spelling of auxiliary in errors.
2298 * doc/binutils.texi: Correct grammar.
2299 * readelf.c (process_version_sections): Correct spelling of auxiliary
2300 in warning.
2301 * testsuite/binutils-all/vax/objdump.exp: Comment grammar fix.
2302
2303 2021-01-01 Alan Modra <amodra@gmail.com>
2304
2305 Update year range in copyright notice of all files.
2306
2307 For older changes see ChangeLog-2020
2308 \f
2309 Copyright (C) 2021-2023 Free Software Foundation, Inc.
2310
2311 Copying and distribution of this file, with or without modification,
2312 are permitted in any medium without royalty provided the copyright
2313 notice and this notice are preserved.
2314
2315 Local Variables:
2316 mode: change-log
2317 left-margin: 8
2318 fill-column: 74
2319 version-control: never
2320 End: