projects / yosys.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ce24208) | patch
verilog: fix size and signedness of array querying functions
authorJannis Harder <me@jix.one>
Fri, 20 May 2022 19:46:39 +0000 (21:46 +0200)
committerZachary Snow <zachary.j.snow@gmail.com>
Mon, 30 May 2022 13:11:31 +0000 (09:11 -0400)
commit4bfaaea0d52c235bb51c4dc54b07fe301eebe473
treeff66a42daace95c965c6851036f907771d61af25tree
parentce24208a8bf74c25868c5073b0ff68a76b71d99fcommit | diff
verilog: fix size and signedness of array querying functions

genrtlil.cc and simplify.cc had inconsistent and slightly broken
handling of signedness for array querying functions. These functions are
defined to return a signed result. Simplify always produced an unsigned
and genrtlil always a signed 32-bit result ignoring the context.

Includes tests for the the relvant edge cases for context dependent
conversions.
CHANGELOG diff | blob | history
frontends/ast/genrtlil.cc diff | blob | history
frontends/ast/simplify.cc diff | blob | history
tests/verilog/sign_array_query.ys [new file with mode: 0644] blob