This fixes some int arithmetic issues and a bogus truncation.
2021-01-20 Richard Biener <rguenther@suse.de>
PR tree-optimization/98758
* tree-data-ref.c (int_divides_p): Use lambda_int arguments.
(lambda_matrix_right_hermite): Avoid undefinedness with
signed integer abs and multiplication.
(analyze_subscript_affine_affine): Use lambda_int.
* gcc.dg/torture/pr98758.c: New testcase.
--- /dev/null
+/* { dg-do compile } */
+
+long *a, *b;
+long c;
+void d(void)
+{
+ b = a;
+ while (c) {
+ *a = (__INTPTR_TYPE__)(a += (long)1 << (sizeof(long) * 8 - 10));
+ c = b[0];
+ b = a;
+ }
+}
/* Returns true iff A divides B. */
static inline bool
/* Returns true iff A divides B. */
static inline bool
-int_divides_p (int a, int b)
+int_divides_p (lambda_int a, lambda_int b)
{
return ((b % a) == 0);
}
{
return ((b % a) == 0);
}
a = S[i-1][j];
b = S[i][j];
a = S[i-1][j];
b = S[i][j];
- sigma = (a * b < 0) ? -1: 1;
- a = abs_hwi (a);
- b = abs_hwi (b);
- factor = sigma * (a / b);
+ sigma = ((a < 0) ^ (b < 0)) ? -1: 1;
+ unsigned HOST_WIDE_INT abs_a = absu_hwi (a);
+ unsigned HOST_WIDE_INT abs_b = absu_hwi (b);
+ factor = sigma * (lambda_int)(abs_a / abs_b);
lambda_matrix_row_add (S, n, i, i-1, -factor);
std::swap (S[i], S[i-1]);
lambda_matrix_row_add (S, n, i, i-1, -factor);
std::swap (S[i], S[i-1]);
tree *last_conflicts)
{
unsigned nb_vars_a, nb_vars_b, dim;
tree *last_conflicts)
{
unsigned nb_vars_a, nb_vars_b, dim;
- HOST_WIDE_INT gamma, gcd_alpha_beta;
+ lambda_int gamma, gcd_alpha_beta;
lambda_matrix A, U, S;
struct obstack scratch_obstack;
lambda_matrix A, U, S;
struct obstack scratch_obstack;