Make IPA-SRA follow comdat-local rules (PR 91956)

2019-11-25  Martin Jambor  <mjambor@suse.cz>

	PR ipa/91956
	* ipa-sra.c (process_isra_node_results): Put the new node to the
	same comdat group as the original node.

	testsuite/
	* g++.dg/ipa/pr91956.C: New test.

From-SVN: r278669

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 25adf2ee635febcb2b6b25a1b1b5c52db5f4aa1a..a15cc758e541c771daad8e9a78a30481a3b2418f 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2019-11-25  Martin Jambor  <mjambor@suse.cz>
+
+       PR ipa/91956
+       * ipa-sra.c (process_isra_node_results): Put the new node to the
+       same comdat group as the original node.
+
 2019-11-25  Georg-Johann Lay  <avr@gjlay.de>
 
        Build double32 / long-double32 multilibs if needed.

diff --git a/gcc/ipa-sra.c b/gcc/ipa-sra.c
index 08606aeded16a2e07bef54e9e564711e8385be03..c6ed0f44b8775352129eb94841ee2189206170d1 100644 (file)
--- a/gcc/ipa-sra.c
+++ b/gcc/ipa-sra.c
@@ -3759,6 +3759,9 @@ process_isra_node_results (cgraph_node *node,
     = node->create_virtual_clone (callers, NULL, new_adjustments, "isra",
                                  suffix_counter);
   suffix_counter++;
+  if (node->same_comdat_group)
+    new_node->add_to_same_comdat_group (node);
+  new_node->calls_comdat_local = node->calls_comdat_local;
 
   if (dump_file)
     fprintf (dump_file, "  Created new node %s\n", new_node->dump_name ());

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 9ff8a951623ed3bfc69f225708e3c56d529bcf2e..ce59906e8c90304669f5a2a09dad6a49c14fa354 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-25  Martin Jambor  <mjambor@suse.cz>
+
+       PR ipa/91956
+       * g++.dg/ipa/pr91956.C: New test.
+
 2019-11-23  Thomas Koenig  <tkoenig@gcc.gnu.org>
        Harald Anlauf <anlauf@gmx.de>
 

diff --git a/gcc/testsuite/g++.dg/ipa/pr91956.C b/gcc/testsuite/g++.dg/ipa/pr91956.C
new file mode 100644 (file)
index 0000000..6f6edc3
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ipa/pr91956.C
@@ -0,0 +1,27 @@
+/* { dg-do compile } */
+/* { dg-options "-Os -std=c++11 -fno-strict-aliasing -fno-tree-fre -fno-tree-vrp"  } */
+
+int count = 0;
+struct VB
+{
+  VB() {++count;}
+};
+
+struct B : virtual VB
+{
+  B() : B(42) {}
+  B(int)  {}
+};
+
+struct D : B
+{
+  D() {}
+  D(int) : D() {}
+};
+
+int main()
+{
+  D d{42};
+  if (count != 1)
+    __builtin_abort();
+}