[gdb/tui] Fix Wmaybe-uninitialized in tui_find_disassembly_address
authorTom de Vries <tdevries@suse.de>
Mon, 13 Nov 2023 08:31:20 +0000 (09:31 +0100)
committerTom de Vries <tdevries@suse.de>
Mon, 13 Nov 2023 08:31:20 +0000 (09:31 +0100)
commit6b682bbf86f37982ce1d270fb47f363413490bda
tree10141f97016d2c71c46df045162f597ffefef1e8
parentaba9fa5f4be8c27e07c5330957fff17e4160920b
[gdb/tui] Fix Wmaybe-uninitialized in tui_find_disassembly_address

When building gdb with -O2, we run into:
...
gdb/tui/tui-disasm.c: In function ‘CORE_ADDR tui_find_disassembly_address \
  (gdbarch*, CORE_ADDR, int)’:
gdb/tui/tui-disasm.c:293:7: warning: ‘last_addr’ may be used uninitialized \
  in this function [-Wmaybe-uninitialized]
       if (last_addr < pc)
       ^~
...

The warning triggers since commit 72535eb14bd ("[gdb/tui] Fix segfault in
tui_find_disassembly_address").

Fix the warning by ensuring that last_addr is initialized at the point of
use:
...
+      last_addr = asm_lines.back ().addr;
       if (last_addr < pc)
...

Tested on x86_64-linux.
gdb/tui/tui-disasm.c