style: eliminate equality tests with true and false stable_2014_08_26
authorSteve Reinhardt <steve.reinhardt@amd.com>
Sun, 1 Jun 2014 01:00:23 +0000 (18:00 -0700)
committerSteve Reinhardt <steve.reinhardt@amd.com>
Sun, 1 Jun 2014 01:00:23 +0000 (18:00 -0700)
commit0be64ffe2f4ff8824b3084362706ffbf456ea490
tree795d803dcfaa3b92faa1155ce2c835daf2d76290
parent2a8088f5aec433b6a1a2330f4fbc29ae28b5ee73
style: eliminate equality tests with true and false

Using '== true' in a boolean expression is totally redundant,
and using '== false' is pretty verbose (and arguably less
readable in most cases) compared to '!'.

It's somewhat of a pet peeve, perhaps, but I had some time
waiting for some tests to run and decided to clean these up.

Unfortunately, SLICC appears not to have the '!' operator,
so I had to leave the '== false' tests in the SLICC code.
24 files changed:
src/arch/mips/tlb.cc
src/arch/power/tlb.cc
src/arch/sparc/tlb.cc
src/arch/x86/pagetable_walker.cc
src/base/loader/hex_file.cc
src/base/match.cc
src/cpu/exetrace.cc
src/cpu/inorder/cpu.cc
src/cpu/inorder/pipeline_stage.cc
src/cpu/inorder/resources/use_def.cc
src/cpu/o3/commit_impl.hh
src/cpu/o3/fetch_impl.hh
src/cpu/o3/iew_impl.hh
src/cpu/o3/inst_queue_impl.hh
src/cpu/o3/lsq_unit_impl.hh
src/cpu/o3/rob_impl.hh
src/cpu/ozone/inst_queue_impl.hh
src/mem/protocol/MOESI_CMP_token-L1cache.sm
src/mem/protocol/MOESI_CMP_token-L2cache.sm
src/mem/protocol/MOESI_CMP_token-dir.sm
src/mem/ruby/buffers/MessageBuffer.cc
src/mem/ruby/slicc_interface/NetworkMessage.hh
src/mem/ruby/system/DMASequencer.cc
src/mem/slicc/ast/PeekStatementAST.py