X-Git-Url: https://git.libre-soc.org/?a=blobdiff_plain;f=cpu_decoder.py;h=c92fb8898daea15443b74c506b45efc328ed603e;hb=1d775c915241d0a84f1deae950ce643aa9ef64c2;hp=995a04c1a4d9db41cb7d58912b142d38f9519d64;hpb=a86b89389e3a62ce131ffe8481b92ac3edf7e41b;p=rv32.git

diff --git a/cpu_decoder.py b/cpu_decoder.py
index 995a04c..c92fb88 100644
--- a/cpu_decoder.py
+++ b/cpu_decoder.py
@@ -154,7 +154,7 @@ class CPUDecoder(Module):
         return self._decode_funct3(DA.jalr, [F3.jalr, ])
 
     def calculate_op_action(self):
-        """ decode op action
+        """ decode op action: the arith ops, and, or, add, xor, sr/sl etc.
         """
         c = {}
         immz = Constant(0, 12)
@@ -178,7 +178,7 @@ class CPUDecoder(Module):
         return Case(self.funct3, c)
 
     def calculate_misc_action(self):
-        """ decode misc mem action
+        """ decode misc mem action: fence and fence_i
         """
         c = {}
         immz = Constant(0, 12)
@@ -203,14 +203,14 @@ class CPUDecoder(Module):
         return Case(self.funct3, c)
 
     def calculate_system_action(self):
-        """ decode system action
+        """ decode opcode system: ebreak and csrs
         """
         c = {}
         b1 = Constant(1, 32)
         regz = Constant(0, 5)
         # ebreak
         c[F3.ecall_ebreak] = \
-            If((self.immediate == ~b1) ^ (self.rs1 == regz) & \
+            If((self.immediate == ~b1) & (self.rs1 == regz) & \
                                          (self.rd == regz),
                 self.decode_action.eq(DA.trap_ecall_ebreak)
             ).Else(