LoongArch: Fix R_LARCH_IRELATIVE insertion after elf_link_sort_relocs

loongarch_elf_finish_dynamic_symbol is called after elf_link_sort_relocs
if -z combreloc.  elf_link_sort_relocs redistributes the contents of
.rela.* sections those would be merged into .rela.dyn, so the slot for
R_LARCH_IRELATIVE may be out of relplt->contents now.

To make things worse, the boundary check

    dyn < dyn + relplt->size / sizeof (*dyn)

is obviously wrong ("x + 10 < x"? :), causing the issue undetected
during the linking process and the resulted executable suddenly crashes
at runtime.

The issue was found during an attempt to add static-pie support to the
toolchain.

Fix it by iterating through the inputs of .rela.dyn to find the slot.

diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index af18a8a01680cffe0535ec3fa967f7dae7526545..33c85e5207c79cb628226e327390df37fb300ef2 100644 (file)
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -3514,6 +3514,12 @@ loongarch_elf_finish_dynamic_symbol (bfd *output_bfd,
 {
   struct loongarch_elf_link_hash_table *htab = loongarch_elf_hash_table (info);
   const struct elf_backend_data *bed = get_elf_backend_data (output_bfd);
+  asection *rela_dyn = bfd_get_section_by_name (output_bfd, ".rela.dyn");
+  struct bfd_link_order *lo = NULL;
+  Elf_Internal_Rela *slot = NULL, *last_slot = NULL;
+
+  if (rela_dyn)
+    lo = rela_dyn->map_head.link_order;
 
   if (h->plt.offset != MINUS_ONE)
     {
@@ -3523,6 +3529,7 @@ loongarch_elf_finish_dynamic_symbol (bfd *output_bfd,
       uint32_t plt_entry[PLT_ENTRY_INSNS];
       bfd_byte *loc;
       Elf_Internal_Rela rela;
+      asection *rela_sec = NULL;
 
       if (htab->elf.splt)
        {
@@ -3575,31 +3582,31 @@ loongarch_elf_finish_dynamic_symbol (bfd *output_bfd,
          && (relplt == htab->elf.srelgot
              || relplt == htab->elf.irelplt))
        {
-           {
-             rela.r_info = ELFNN_R_INFO (0, R_LARCH_IRELATIVE);
-             rela.r_addend = (h->root.u.def.value
+         rela.r_info = ELFNN_R_INFO (0, R_LARCH_IRELATIVE);
+         rela.r_addend = (h->root.u.def.value
                               + h->root.u.def.section->output_section->vma
                               + h->root.u.def.section->output_offset);
-           }
 
-           /* Find the space after dyn sort.  */
+         /* Find the space after dyn sort.  */
+         while (slot == last_slot || slot->r_offset != 0)
            {
-             Elf_Internal_Rela *dyn = (Elf_Internal_Rela *)relplt->contents;
-             bool fill = false;
-             for (;dyn < dyn + relplt->size / sizeof (*dyn); dyn++)
+             if (slot != last_slot)
                {
-                 if (0 == dyn->r_offset)
-                   {
-                     bed->s->swap_reloca_out (output_bfd, &rela,
-                                              (bfd_byte *)dyn);
-                     relplt->reloc_count++;
-                     fill = true;
-                     break;
-                   }
+                 slot++;
+                 continue;
                }
-             BFD_ASSERT (fill);
+
+             BFD_ASSERT (lo != NULL);
+             rela_sec = lo->u.indirect.section;
+             lo = lo->next;
+
+             slot = (Elf_Internal_Rela *)rela_sec->contents;
+             last_slot = (Elf_Internal_Rela *)(rela_sec->contents +
+                                               rela_sec->size);
            }
 
+         bed->s->swap_reloca_out (output_bfd, &rela, (bfd_byte *)slot);
+         rela_sec->reloc_count++;
        }
       else
        {

diff --git a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
index dfa8ee18865ad32a3b4f54450d299213462ae2b1..726ee8237018cfb5619e690bf1d410206d822b93 100644 (file)
--- a/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
+++ b/ld/testsuite/ld-loongarch-elf/ld-loongarch-elf.exp
@@ -31,6 +31,7 @@ if [istarget "loongarch64-*-*"] {
     run_dump_test "macro_op"
     run_dump_test "syscall"
     run_dump_test "disas-jirl"
+    run_dump_test "local-ifunc-reloc"
 }
 
 if [istarget "loongarch32-*-*"] {

diff --git a/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d b/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d
new file mode 100644 (file)
index 0000000..29f2d3f
--- /dev/null
+++ b/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.d
@@ -0,0 +1,10 @@
+#as:
+#ld: -shared -z combreloc
+#objdump: -R
+
+.*: +file format .*
+
+DYNAMIC RELOCATION RECORDS
+OFFSET +TYPE +VALUE
+[[:xdigit:]]+ R_LARCH_IRELATIVE +\*ABS\*\+0x[[:xdigit:]]+
+[[:xdigit:]]+ R_LARCH_64 +test

diff --git a/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.s b/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.s
new file mode 100644 (file)
index 0000000..77c4874
--- /dev/null
+++ b/ld/testsuite/ld-loongarch-elf/local-ifunc-reloc.s
@@ -0,0 +1,28 @@
+.text
+.align 2
+
+.local ifunc
+.type ifunc, @gnu_indirect_function
+.set ifunc, resolver
+
+resolver:
+  la.local $a0, impl
+  jr $ra
+
+impl:
+  li.w $a0, 42
+  jr $ra
+
+.global test
+.type test, @function
+test:
+  move $s0, $ra
+  bl ifunc
+  xori $a0, $a0, 42
+  jr $s0
+
+.data
+.global ptr
+.type ptr, @object
+ptr:
+  .dword test