(no commit message)
[libreriscv.git] / HDL_workflow.mdwn
1 # HDL workflow
2
3 This section describes the workflow and some best practices for developing
4 the Libre-SoC hardware. We use nmigen, yosys and symbiyosys, and this
5 page is intended not just to help you get set up, it is intended to
6 help advise you of some tricks and practices that will help you become
7 effective team contributors.
8
9 It is particularly important to bear in mind that we are not just
10 "developing code", here: we are creating a "lasting legacy educational
11 resource" for other people to learn from, and for businesses and students
12 alike to be able to use, learn from and augment for their own purposes.
13
14 It is also important to appreciate and respect that we are funded under
15 NLNet's Privacy and Enhanced Trust Programme <http://nlnet.nl/PET>. Full
16 transparency, readability, documentation, effective team communication
17 and formal mathematical proofs for all code at all levels is therefore
18 paramount.
19
20 # Collaboration resources
21
22 The main message here: **use the right tool for the right job**.
23
24 * mailing list: general communication and discussion.
25 * bugtracker: task-orientated, goal-orientated *focussed* discussion.
26 * ikiwiki: document store, information store, and (editable) main website
27 * git repositories: code stores (**not binary or auto-generated output store**)
28 * ftp server (<http://ftp.libre-riscv.org>): large file store.
29
30 we will add an IRC channel at some point when there are enough people
31 to warrant having one.
32
33 note also the lack of a "forum" in the above list. this is very deliberate. forums are a serious distraction when it comes to technical heavily goal-orientated development. recent internet users may enjoy looking up the "AOL metoo postings" meme.
34
35 note also the complete lack of "social platforms". if we wanted to tell everybody how much better each of us are than anyone else in the team, how many times we made a commit (look at me, look at me, i'm so clever), and how many times we went to the bathroom, we would have installed a social media based project "management" system.
36
37 ## Main contact method: mailing list
38
39 To respect the transparency requirements, conversations need to be
40 public and archived (i.e not skype, not telegram, not discord,
41 and anyone seriously suggesting slack will be thrown to the
42 lions). Therefore we have a mailing list. Everything goes through
43 there. <http://lists.libre-riscv.org/mailman/listinfo/libre-riscv-dev>
44 therefore please do google "mailing list etiquette" and at the very
45 minimum look up and understand the following:
46
47 * This is a technical mailing list with complex topics. Top posting
48 is completely inappropriate. Don't do it unless you have mitigating
49 circumstances, and even then please apologise and explain ("hello sorry
50 using phone at airport flight soon, v. quick reply: ....")
51 * Always trim context but do not cut excessively to the point where people
52 cannot follow the discussion. Especially do not cut the attribution
53 ("On monday xxx wrote")
54 * Use inline replies i.e. reply at the point in the relevant part of
55 the conversation, as if you were actually having a conversation.
56 * Follow standard IETF reply formatting, using ">" for cascaded
57 indentation of other people's replies. If using gmail, please: SWITCH
58 OFF RICH TEXT EDITING.
59 * Please for god's sake do not use "my replies are in a different
60 colour". Only old and highly regarded people still using AOL are allowed
61 to get away with that (such as Mitch).
62 * Start a new topic with a relevant subject line. If an existing
63 discussion changes direction, change the subject line to reflect the
64 new topic (or start a new conversation entirely, without using the
65 "reply" button)
66 * DMARC is a pain on the neck. Try to avoid GPG signed messages. sigh.
67 * Don't send massive attachments. Put them online (no, not on facebook or
68 google drive or anywhere else that demands privacy violations) and provide
69 the link. Which should not require any kind of login to access. ask the
70 listadmin if you don't have anywhere suitable: FTP access can be arranged.
71
72 ### Actionable items from mailing list
73
74 If discussions result in any actionable items, it is important not to
75 lose track of them. Create a bugreport, find the discussion in the
76 archives <http://lists.libre-riscv.org/pipermail/libre-riscv-dev/>,
77 and put the link actually in the bugtracker as one of the comments.
78
79 At some point in any discussion, the sudden realisation may dawn on one
80 or more people that this is an "actionable" discussion. at that point
81 it may become better to use <http://bugs.libre-riscv.org>
82 itself to continue the discussion rather than to keep on dropping copies
83 of links into the bugtracker. The bugtracker sends copies of comments
84 *to* the list however this is 'one-way' (note from lkcl: because this
85 involves running an automated perl script from email, on every email,
86 on the server, that is a high security risk, and i'm not doing it. sorry.)
87
88 ### Mailing list != editable document store
89
90 Also, please do not use the mailing list as an "information or document
91 store or poor-man's editor". We have the wiki for that. Edit a page and
92 tell people what you did (summarise rather than drop the entire contents
93 at the list) and include the link to the page.
94
95 Or, if it is more appropriate, commit a document (or source code)
96 into the relevant git repository then look up the link in the gitweb
97 source tree browser and post that (in the bugtracker or mailing list)
98 See <http://git.libre-riscv.org>
99
100 ### gmail "spam"ifying the list
101
102 see <https://blog.kittycooper.com/2014/05/keeping-my-mailing-list-emails-out-of-gmails-spam-folder/>
103
104 basically it is possible to select any message from the list, create a "filter" (under "More"),
105 and, on the 2nd dialog box, click the "never send this to Spam" option.
106
107 ## Bugtracker
108
109 bugzilla. old and highly effective. sign up in the usual way. any
110 problems, ask on the list.
111
112 Please do not ask for the project to be transferred to github or other
113 proprietary nonfree service "because it's soooo convenient", as the
114 lions are getting wind and gout from overfeeding on that one.
115
116 ## ikiwiki
117
118 Runs the main libre-riscv.org site (including this page). effective,
119 stunningly light on resources, and uses a git repository not a database.
120 That means it can be edited offline.
121
122 Usual deal: register an account and you can start editing and contributing
123 straight away.
124
125 Hint: to create a new page, find a suitable page that would link to it,
126 first, then put the link in of the page you want to create, as if the
127 page already exists. Save that page, and you will find a questionmark
128 next to the new link you created. click that link, and it will fire up a
129 "create new page" editor.
130
131 Hint again: the wiki is backed by a git repository. Don't go overboard
132 but at the same time do not be afraid that you might "damage" or "lose"
133 pages. Although it would be a minor pain, the pages can always be
134 reverted or edited by the sysadmins to restore things if you get in a tiz.
135
136 Assistance in creating a much better theme greatly appreciated. e.g.
137 <http://www.math.cmu.edu/~gautam/sj/blog/20140720-ikiwiki-navbar.html>
138
139 ## git
140
141 we use git. more on this below. we also use gitolite3 running on a
142 dedicated server. again, it is extremely effective and low resource
143 utilisation. reminder: lions are involved if github is mentioned.
144
145 gitweb is provided which does a decent job. <http://git.libre-riscv.org>
146
147 ## ftp server
148
149 <http://ftp.libre-riscv.org> is available for storing large files
150 that do not belong in a git repository, if we have (or ever need)
151 any. images (etc.) if small and appropriate should go into the
152 wiki, however .tgz archives (etc.) and, at some point, binaries,
153 should be on the ftp server.
154
155 ask on the list if you have a file that belongs on the ftp server.
156
157 ## server
158
159 as an aside: all this is "old school" and run on a single core 512MB
160 VM with only a 20GB HDD allocation. it costs only 8 GBP per month from
161 mythic-beasts and means that the project is in no way dependent on anyone
162 else - not microsoft, not google, not facebook, not amazon.
163
164 we tried gitlab. it didn't go well. please don't ask to replace the
165 above extremely resource-efficient services with it.
166
167 # Hardware
168
169 RAM is the biggest requirement. Minimum 16GB, the more the better (32
170 or 64GB starts to reach "acceptable" levels. Disk space is not hugely
171 critical: 256GB SSD should be more than adequate. Simulations and
172 FPGA compilations however are where raw processing power is a must.
173 High end Graphics Cards are nonessential.
174
175 What is particularly useful is to have hi-res screens (curved is
176 *strongly* recommended if the LCD is over 24in wide, to avoid eyeballs
177 going "prism" through longterm use), and to have several of them: the
178 more the better. Either a DisplayLink UD160A (or more modern variant)
179 or simply using a second machine (lower spec hardware because it will
180 run editors) is really effective.
181
182 Also it is really recommended to have a UHD monitor (4k - 3840x2160),
183 or at least 2560x1200. If given a choice, 4:3 aspect ratio is better
184 than 16:9 particularly when using several of them. However, caveat
185 (details below): please when editing do not assume that everyone will
186 have access to such high resolution screens.
187
188 # Operating System
189
190 First install and become familiar with Debian (ubuntu if you absolutely
191 must) for standardisation cross-team and so that toolchain installation
192 is greatly simplified. yosys in particular warns that trying to use
193 Windows, BSD or MacOS will get you into a world of pain.
194
195 Only a basic GUI desktop is necessary: fvwm2, xfce4, lxde are perfectly
196 sufficient (alongside wicd-gtk for network management). Other more
197 complex desktops can be used however may consume greater resources.
198
199 # editors and editing
200
201 Whilst this is often a personal choice, the fact that many editors are
202 GUI based and run fullscreen with the entire right hand side *and* middle
203 *and* the majority of the left side of the hi-res screen entirely unused
204 and bereft of text leaves experienced developers both amused and puzzled.
205
206 At the point where such fullscreen users commit code with line lengths
207 well over 160 characters, that amusement quickly evaporates.
208
209 Where the problems occur with fullscreen editor usage is when a project
210 is split into dozens if not hundreds of small files (as this one is). At
211 that point it becomes pretty much essential to have as many as six to
212 eight files open *and on-screen* at once, without overlaps i.e. not in
213 hidden tabs, next to at least two if not three additional free and clear
214 terminals into which commands are regularly and routinely typed (make,
215 git commit, nosetests3 etc). Illustrated with the following 3840x2160
216 screenshot (click to view full image), where *every one* of those 80x70
217 xterm windows is *relevant to the task at hand*.
218
219 [[!img 2020-01-24_11-56.png size=640x ]]
220
221 (hint/tip: fvwm2 set up with "mouse-over to raise focus, rather than
222 additionally requiring a mouseclick, can save a huge amount of cumulative
223 development time here, switching between editor terminal(s) and the
224 command terminals).
225
226 Once this becomes necessary, it it turn implies that having greater
227 than 80 chars per line - and running editors fullscreen - is a severe
228 hindance to an essential *and highly effective* workflow technique.
229
230 Additionally, care should be taken to respect that not everyone will have
231 200+ column editor windows and the eyesight of a hawk. They may only have
232 a 1280 x 800 laptop which barely fits two 80x53 xterms side by side.
233 Consequently, having excessively long functions is also a hindrance to
234 others, as such developers with limited screen resources would need to
235 continuously page-up and page-down to read the code even of a single
236 function, in full.
237
238 This helps explain in part, below, why compliance with pep8 is enforced,
239 including its 80 character limit. In short: not everyone has the same
240 "modern" GUI workflow or has access to the same computing resources as
241 you, so please do respect that.
242
243 # Software prerequisites
244
245 Whilst many resources online advocate "sudo" in front of all root-level
246 commands below, this quickly becomes tiresome. run "sudo bash", get a
247 root prompt, and save yourself some typing.
248
249 * sudo bash
250 * apt-get install vim exuberant-ctags
251 * apt-get install build-essential
252 * apt-get install git python3.7 python3.7-dev python-nosetest3
253 * apt-get install graphviz xdot gtkwave
254 * return to user prompt (ctrl-d)
255
256 This will get you python3 and other tools that are needed. graphviz is
257 essential for showing the interconnections between cells, and gtkwave
258 is essential for debugging.
259
260 ## git
261
262 Look up good tutorials on how to use git effectively. There are so many
263 it is hard to recommend one. This is however essential. If you are not
264 comfortable with git, and you let things stay that way, it will seriously
265 impede development progress.
266
267 If working all day you should expect to be making at least two commits per
268 hour, so should become familiar with it very quickly. If you are *not*
269 doing around 2 commits per hour, something is wrong and you should read
270 the workflow instructions below more carefully, and also ask for advice
271 on the mailing list.
272
273 Worth noting: *this project does not use branches*. All code is committed
274 to master and we *require* that it be either zero-impact additions or that
275 relevant unit tests pass 100%. This ensures that people's work does not
276 get "lost" or isolated and out of touch due to major branch diversion,
277 and that people communicate and coordinate with each other.
278
279 ## yosys
280
281 Follow the source code (git clone) instructions here:
282 <http://www.clifford.at/yosys/download.html>
283
284 Do not try to use a fixed revision (currently 0.9), nmigen is evolving
285 and frequently interacts with yosys
286
287 ## symbiyosys
288
289 Follow the instructions here:
290 <https://symbiyosys.readthedocs.io/en/latest/quickstart.html#installing>
291
292 You do not have to install all of those (avy, boolector can be left
293 out if desired) however the more that are installed the more effective
294 the formal proof scripts will be (less resource utilisation in certain
295 circumstances).
296
297 ## nmigen
298
299 nmigen may be installed as follows:
300
301 * mkdir ~/src
302 * cd !$
303 * git clone https://github.com/m-labs/nmigen.git
304 * cd nmigen
305 * sudo bash
306 * python3 setup.py develop
307 * ctrl-d
308
309 testing can then be carried out with "python3 setup.py test"
310
311 ## Softfloat and sfpy
312
313 These are a test suite dependency for the ieee754fpu library, and
314 will be changed in the future to use Jacob's algorithmic numeric
315 library. In the meantime, sfpy can be built as follows:
316
317 git clone --recursive https://github.com/billzorn/sfpy.git
318 cd sfpy
319 cd SoftPosit
320 git apply ../softposit_sfpy_build.patch
321 git apply /path/to/ieee754fpu/SoftPosit.patch
322 cd ../berkely-softfloat-3
323 # Note: Do not apply the patch included in sfpy for berkely-softfloat,
324 # it contains the same changes as this one
325 git apply /path/to/ieee754fpu/berkeley-softfloat.patch
326 cd ..
327
328 # install dependencies
329 python3 -m venv .env
330 . .env/bin/activate
331 pip3 install --upgrade -r requirements.txt
332
333 # build
334 make lib -j8
335 make cython
336 make inplace -j8
337 make wheel
338
339 # install
340 deactivate # deactivates venv, optional
341 pip3 install dist/sfpy*.whl
342
343 You can test your installation by doing the following:
344
345 python3
346 >>> from sfpy import *
347 >>> Posit8(1.3)
348
349 It should print out `Posit8(1.3125)`
350
351 ## Coriolis2
352
353 See [[coriolis2]] page, for those people doing layout work.
354
355 # Registering for git repository access
356
357 After going through the onboarding process and having agreed to take
358 responsibility for certain tasks, ask on the mailing list for git
359 repository access, sending in a public key (id_rsa.pub). If you do
360 not have one then generate it with ssh-keygen -t rsa. You will find it
361 in ~/.ssh
362
363 NEVER SEND ANYONE THE PRIVATE KEY. By contrast the public key, on
364 account of being public, is perfectly fine to make... err... public.
365
366 Create a file ~/.ssh/config with the following lines:
367
368 Host git.libre-riscv.org
369 Port 922
370
371 Wait for the Project Admin to confirm that the ssh key has been added
372 to the required repositories. Once confirmed, you can clone any of the
373 repos at http://git.libre-riscv.org:
374
375 git clone gitolite3@git.libre-riscv.org:REPONAME.git
376
377 Alternatively, the .ssh/config can be skipped and this used:
378
379 git clone ssh://gitolite3@git.libre-riscv.org:922/REPONAME.git
380
381 # git configuration
382
383 Although there are methods online which describe how (and why) these
384 settings are normally done, honestly it is simpler and easier to open
385 ~/.gitconfig and add them by hand.
386
387 core.autocrlf is a good idea to ensure that anyone adding DOS-formatted
388 files they don't become a pain. pull.rebase is something that is greatly
389 preferred for this project because it avoids the mess of "multiple
390 extra merge git tree entries", and branch.autosetuprebase=always will,
391 if you want it, always ensure that a new git checkout is set up with rebase.
392
393 [core]
394 autocrlf = input
395 [push]
396 default = simple
397 [pull]
398 rebase = true
399 [branch]
400 autosetuprebase = always
401
402 # Checking out the HDL repositories
403
404 * mkdir ~/src
405 * cd !$
406 * git clone gitolite3@git.libre-riscv.org:nmutil.git
407 * git clone gitolite3@git.libre-riscv.org:ieee754fpu.git
408 * git clone gitolite3@git.libre-riscv.org:soc.git
409
410 In each of these directories, in the order listed, track down the
411 setup.py file, then, as root (sudo bash), run the following:
412
413 * python3 setup.py develop
414
415 The reason for using "develop" mode is that the code may be edited
416 in-place yet still imported "globally". There are variants on this theme
417 for multi-user machine use however it is often just easier to get your
418 own machine these days.
419
420 The reason for the order is because soc depends on ieee754fpu, and
421 ieee754fpu depends on nmutil
422
423 If "python3 setup.py install" is used it is a pain: edit, then
424 install. edit, then install. It gets extremely tedious, hence why
425 "develop" was created.
426
427 # Development Rules
428
429 team communication:
430
431 * new members, add yourself to the [[about_us]] page and create yourself a home page using someone else's page as a template.
432 * communicate on the mailing list or the bugtracker an intent to take
433 responsibility for a particular task.
434 * assign yourself as the bug's owner
435 * *keep in touch* about what you are doing, and why you are doing it.
436 * edit your home page regularly, particularly to track tasks so that they can be paid by NLNet.
437 * if you cannot do something that you have taken responsibility for,
438 then unless it is a dire personal emergency please say so, on-list. we
439 won't mind. we'll help sort it out.
440
441 regarding the above it is important that you read, understand, and agree
442 to the [[charter]] because the charter is about ensuring that we operate
443 as an effective organisation. It's *not* about "setting rules and meting
444 out punishment".
445
446 ## Coding
447
448 for actual code development
449
450 ### Plan unit tests
451
452 * plan in advance to write not just code but a full test suite for
453 that code. **this is not optional**. large python projects that do not
454 have unit tests **FAIL** (see separate section below).
455 * Prioritise writing formal proofs and a single clear unit test that is more like a "worked example".
456 We receive NLNet funds for writing formal proofs, plus they
457 cover corner cases and take far less time to write
458
459 ### Commit tested or zero-dependent code
460
461 * only commit code that has been tested (or is presently unused). other
462 people will be depending on you, so do take care not to screw up.
463 not least because, as it says in the [[charter]] it will be your
464 responsibility to fix. that said, do not feel intimidated: ask for help
465 and advice, and you'll get it straight away.
466
467 ### Commit often
468
469 * commit often. several times a day, and "git push" it. this is
470 collaboration. if something is left even overnight uncommitted and not
471 pushed so that other people can see it, it is a red flag. if you find
472 yourself thinking "i'll commit it when it's finished" or "i don't want to
473 commit something that people might criticise" *this is not collaboration*,
474 it is making yourself a bottleneck. pair-programming is supposed to help
475 avoid this kind of thing however pair-programming is difficult to organise
476 for remote collaborative libre projects (suggestions welcomed here)
477
478 ### Absolutely no auto-generated output
479
480 * **do not commit autogenerated output**. write a shell script and commit
481 that, or add a Makefile to run the command that generates the output, but
482 **do not** add the actual output of **any** command to the repository.
483 ever. this is really important. even if it is a human-readable file
484 rather than a binary object file.
485 it is very common to add pdfs (the result of running latex2pdf) or configure.in (the result of running automake), they are an absolute nuisance and interfere hugely with git diffs, as well as waste hard disk space *and* network bandwidth. don't do it.
486
487 ### Write commands that do tasks and commit those
488
489 * if the command needed to create any given autogenerated output is not
490 currently in the list of known project dependencies, first consult on
491 the list if it is okay to make that command become a hard dependency of
492 the project (hint: java, node.js php and .NET commands may cause delays
493 in response time due to other list participants laughing hysterically),
494 and after a decision is made, document the dependency and how its source
495 code is obtained and built (hence why it has to be discussed carefully)
496 * if you find yourself repeating commands regularly, chances are high
497 that someone else will need to run them, too. clearly this includes
498 yourself, therefore, to make everyone's lives easier including your own,
499 put them into a .sh shell script (and/or a Makefile), commit them to
500 the repository and document them at the very minimum in the README,
501 INSTALL.txt or somewhere in a docs folder as appropriate. if unsure,
502 ask on the mailing list for advice.
503
504 ### Keep commits single-purpose
505
506 * edit files making minimal *single purpose* modifications (even if
507 it involves multiple files. Good extreme example: globally changing
508 a function name across an entire codebase is one purpose, one commit,
509 yet hundreds of files. miss out one of those files, requiring multiple
510 commits, and it actually becomes a nuisance).
511
512 ### Run unit tests prior to commits
513
514 * prior to committing make sure that relevant unit tests pass, or that
515 the change is a zero-impact addition (no unit tests fail at the minimum)
516
517 ### Do not break existing code
518
519 * keep working code working **at all times**. find ways to ensure that this is the case. examples include writing alternative classes that replace existing functionality and adding runtime optiobs to select between old and new code.
520
521 ### Small commits with relevant commit message
522
523 * commit no more than around 5 to 10 lines at a time, with a CLEAR message
524 (no "added this" or "changed that").
525 * if as you write you find that the commit message involves a *list* of
526 changes or the word "and", then STOP. do not proceed: it is a "red flag"
527 that the commit has not been properly broken down into separate-purpose
528 commits. ask for advice on-list on how to proceed.
529
530 ### Exceptions to small commit: atomic single purpose commit
531
532 * if it is essential to commit large amounts of code, ensure that it
533 is **not** in use **anywhere** by any other code. then make a *small*
534 (single purpose) followup commit which actually puts that code into use.
535
536 this last rule is kinda flexible, because if you add the code *and* add
537 the unit test *and* added it into the main code *and* ran all relevant
538 unit tests on all cascade-impacted areas by that change, that's perfectly
539 fine too. however if it is the end of a day, and you need to stop and
540 do not have time to run the necessary unit tests, do *not* commit the
541 change which integrates untested code: just commit the new code (only)
542 and follow up the next day *after* running the full relevant unit tests.
543
544 ### Why such strict rules?
545
546 the reason for all the above is because python is a weakly typed language.
547 make one tiny change at the base level of the class hierarchy and the
548 effect may be disastrous.
549
550 it is therefore worth reiterating: make absolutely certain that you *only*
551 commit working code or zero-impact code.
552
553 therefore, if you are absolutely certain that a new addition (new file,
554 new class, new function) is not going to have any side-effects, committing
555 it (a large amount of code) is perfectly fine.
556
557 as a general rule, however, do not use this an an excuse to write code
558 first then write unit tests as an afterthought. write *less* code *in
559 conjunction* with its (more basic) unit tests, instead. then, folliw up with
560 additions and improvements.
561
562 the reason for separating out commits to single purpose only becomes
563 obvious (and regretted if not followed) when, months later, a mistake
564 has to be tracked down and reverted. if the commit does not have an
565 easy-to-find message, it cannot even be located, and once found, if the
566 commit confuses several unrelated changes, not only the diff is larger
567 than it should be, the reversion process becomes extremely painful.
568
569 ### PEP8 format
570
571 * all code needs to conform to pep8. use either pep8checker or better
572 run autopep8. however whenever committing whitespace changes, *make a
573 separate commit* with a commit message "whitespace" or "autopep8 cleanup".
574 * pep8 REQUIRES no more than 80 chars per line. this is non-negotiable. if
575 you think you need greater than 80 chars, it *fundamentally* indicates
576 poor code design. split the code down further into smaller classes
577 and functions.
578
579 ### Docstring checker
580
581 * TBD there is a docstring checker. at the minimum make sure to have
582 an SPD license header, module header docstring, class docstring and
583 function docstrings on at least non-obvious functions.
584
585 ### Clear code commenting and docstrings
586
587 * make liberal but not excessive use of comments. describe a group of
588 lines of code, with terse but useful comments describing the purpose,
589 documenting any side-effects, and anything that could trip you or other
590 developers up. unusual coding techniques should *definitely* contain
591 a warning.
592
593 ### Only one class per module (ish)
594
595 * unless they are very closely related, only have one module (one class)
596 per file. a file only 25 lines long including imports and docstrings
597 is perfectly fine however don't force yourself. again, if unsure,
598 ask on-list.
599
600 ### File and Directory hierarchy
601
602 * *keep files short and simple*. see below as to why
603 * create a decent directory hierarchy but do not go mad. ask for advice
604 if unsure
605
606 ### No import star!
607
608 * please do not use "from module import \*". it is extremely bad practice,
609 causes unnecessary resource utilisation, makes code readability and
610 tracking extremely difficult, and results in unintended side-effects.
611
612 ### Keep file and variables short but clear
613
614 * try to keep both filenames and variable names short but not ridiculously
615 obtuse. an interesting compromise on imports is "from ridiculousfilename
616 import longsillyname as lsn", and to assign variables as well: "comb =
617 m.d.comb" followed by multiple "comb += nmigen_stmt" lines is a good trick
618 that can reduce code indentation by 6 characters without reducing clarity.
619
620 ### Reasons for code structure
621
622 regarding code structure: we decided to go with small modules that are
623 both easy to analyse, as well as fit onto a single page and be readable
624 when displayed as a visual graph on a full UHD monitor. this is done
625 as follows:
626
627 * using the capability of nmigen (TODO crossref to example) output the
628 module to a yosys ilang (.il) file
629 * in a separate terminal window, run yosys
630 * at the yosys prompt type "read_ilang modulename.il"
631 * type "show top" and a graphviz window should appear. note that typing
632 show, then space, then pressing the tab key twice will give a full list
633 of submodules (one of which will be "top")
634
635 you can now fullsize the graphviz window and scroll around. if it looks
636 reasonably obvious at 100% zoom, i.e the connections can be clearly
637 related in your mind back to the actual code (by matching the graph names
638 against signals and modules in the original nmigen code) and the words are
639 not tiny when zoomed out, and connections are not total incomprehensible
640 spaghetti, then congratulations, you have well-designed code. If not,
641 then this indicates a need to split the code further into submodules
642 and do a bit more work.
643
644 The reasons for doing a proper modularisation job are several-fold:
645
646 * firstly, we will not be doing a full automated layout-and-hope
647 using alliance/coriolis2, we will be doing leaf-node thru tree node
648 half-automated half-manual layout, finally getting to the floorplan,
649 then revising and iteratively adjusting.
650 * secondly, examining modules at the gate level (or close to it) is just
651 good practice. poor design creeps in by *not* knowing what the tools
652 are actually doing (word to experienced developers: yes, we know that
653 the yosys graph != final netlist).
654 * thirdly, unit testing, particularly formal proofs, is far easier on
655 small sections of code, and complete in a reasonable time.
656
657 ## Special warning / alert to vim users!
658
659 Some time around the beginning of 2019 some bright spark decided that
660 an "auto-recommend-completion-of-stuff" option would be a nice, shiny
661 idea to enable by default from that point onwards.
662
663 This incredibly annoying "feature" results in tabs (or spaces) being
664 inserted "on your behalf" when you press return on one line, for your
665 "convenience" of not needing to type lots of spaces/tabs just to get
666 to the same indentation level.
667
668 Of course, this "feature", if you press return on one line in edit
669 mode and then press "escape", leaves a bundle-of-joy extraneous
670 whitespace **exactly** where you don't want it, and didn't ask for it,
671 pooped all over your file.
672
673 Therefore, *please*: **before** running "git commit", get into the
674 habit of always running "git diff", and at the very minimum
675 speed-skim the entire diff, looking for tell-tale "red squares"
676 (these show up under bash diff colour-syntax-highlighting) that
677 inform you that, without your knowledge or consent, vim has
678 "helpfully" inserted extraneous whitespace.
679
680 Remove them **before** git committing because they are not part
681 of the actual desired code-modifications, and committing them
682 is a major and constant distraction for reviewers about actual
683 important things like "the code that actually *usefully* was
684 modified for that commit"
685
686 This has the useful side-effect of ensuring that, right before
687 the commit, you've got the actual diff right in front of you
688 in the xterm window, on which you can base the "commit message".
689
690 ## Unit tests
691
692 This deserves its own special section. It is extremely important to
693 appreciate that without unit tests, python projects are simply unviable.
694 Python itself has over 25,000 individual tests.
695
696 This can be quite overwhelming to a beginner developer, especially one
697 used to writing scripts of only 100 lines in length.
698
699 Thanks to Samuel Falvo we learned that writing unit tests as a formal
700 proof is not only shorter, it's also far more readable and also, if
701 written properly, provides 100% coverage of corner-cases that would
702 otherwise be overlooked or require tens to hundreds of thousands of
703 tests to be run.
704
705 No this is not a joke or even remotely hypothetical, this is an actual
706 real-world problem.
707
708 The ieee754fpu requires several hundreds of thousands of tests to be
709 run (currently needing several days to run them all), and even then we
710 cannot be absolutely certain that all possible combinations of input have
711 been tested. With 2^128 permutations to try with 2 64 bit FP numbers
712 it is simply impossible to even try.
713
714 This is where formal proofs come into play.
715
716 Samuel illustrated to us that "ordinary" unit tests can then be written
717 to *augment* the formal ones, serving the purpose of illustrating how
718 to use the module, more than anything.
719
720 However it is appreciated that writing formal proofs is a bit of a
721 black art. This is where team collaboration particularly kicks in,
722 so if you need help, ask on the mailing list.
723
724 # TODO Tutorials
725
726 Find appropriate tutorials for nmigen and yosys, as well as symbiyosys.
727
728 * Although a verilog example this is very useful to do
729 <https://symbiyosys.readthedocs.io/en/latest/quickstart.html#first-step-a-simple-bmc-example>
730 * This tutorial looks pretty good and will get you started
731 <http://blog.lambdaconcept.com/doku.php?id=nmigen:nmigen_install> and
732 walks not just through simulation, it takes you through using gtkwave
733 as well.
734 * There exist several nmigen examples which are also executable
735 <https://github.com/m-labs/nmigen/tree/master/examples/> exactly as
736 described in the above tutorial (python3 filename.py -h)
737 * Robert Baruch's nmigen tutorials look really good:
738 <https://github.com/RobertBaruch/nmigen-tutorial>