ieee754fpu.git
8 months agoswitch to exact version of cython master
Jacob Lifshay [Wed, 16 Aug 2023 02:05:15 +0000 (19:05 -0700)]
switch to exact version of cython

8 months agofix CI
Jacob Lifshay [Wed, 16 Aug 2023 01:56:51 +0000 (18:56 -0700)]
fix CI

8 months agoadd FPSCR with parts
Jacob Lifshay [Sat, 12 Aug 2023 00:52:34 +0000 (17:52 -0700)]
add FPSCR with parts

10 months agouse new pytest config
Jacob Lifshay [Tue, 13 Jun 2023 01:59:01 +0000 (18:59 -0700)]
use new pytest config

20 months agochange all uses of dataclass to plain_data
Jacob Lifshay [Fri, 12 Aug 2022 07:54:36 +0000 (00:54 -0700)]
change all uses of dataclass to plain_data

21 months agochange to correct branch
Jacob Lifshay [Wed, 6 Jul 2022 04:13:10 +0000 (21:13 -0700)]
change to correct branch

21 months agochange nmigen from programmerjake's repo to upstream nmigen
Jacob Lifshay [Wed, 6 Jul 2022 03:56:21 +0000 (20:56 -0700)]
change nmigen from programmerjake's repo to upstream nmigen

21 months agoclean up remaining fixmes for fma
Jacob Lifshay [Mon, 4 Jul 2022 23:21:32 +0000 (16:21 -0700)]
clean up remaining fixmes for fma

21 months agoadd f8 fma tests -- f16 takes >8hr to run with bitwuzla
Jacob Lifshay [Mon, 4 Jul 2022 23:14:36 +0000 (16:14 -0700)]
add f8 fma tests -- f16 takes >8hr to run with bitwuzla

21 months agoworking on implementing fma, f16 rtz formal proof seems likely to work
Jacob Lifshay [Mon, 4 Jul 2022 10:49:45 +0000 (03:49 -0700)]
working on implementing fma, f16 rtz formal proof seems likely to work

bitwuzla has been running the formal proof for the last 23min, seems
like it'll probably succeed after a bunch of time.

21 months agoadd FPFormat.get_exponent_value to get an unbiased exponent corrected for subnormals
Jacob Lifshay [Mon, 4 Jul 2022 10:42:27 +0000 (03:42 -0700)]
add FPFormat.get_exponent_value to get an unbiased exponent corrected for subnormals

21 months agomisc bug fixes and cleanup in fpbase.py
Jacob Lifshay [Mon, 4 Jul 2022 10:41:24 +0000 (03:41 -0700)]
misc bug fixes and cleanup in fpbase.py

21 months agoadd tests for non-power-of-2 shifts for MultiShift* classes
Jacob Lifshay [Mon, 4 Jul 2022 06:18:20 +0000 (23:18 -0700)]
add tests for non-power-of-2 shifts for MultiShift* classes

21 months agofix MultiShift* classes to correctly calculate shift-amount bit width
Jacob Lifshay [Mon, 4 Jul 2022 06:15:14 +0000 (23:15 -0700)]
fix MultiShift* classes to correctly calculate shift-amount bit width

21 months agostart implementing fp fused-mul-add pipeline
Jacob Lifshay [Sat, 2 Jul 2022 02:59:39 +0000 (19:59 -0700)]
start implementing fp fused-mul-add pipeline

https://bugs.libre-soc.org/show_bug.cgi?id=877

21 months agodisable fadd f32 formal proofs by default -- they're too slow
Jacob Lifshay [Sat, 2 Jul 2022 02:54:20 +0000 (19:54 -0700)]
disable fadd f32 formal proofs by default -- they're too slow

21 months agofix copyright years
Jacob Lifshay [Fri, 1 Jul 2022 22:01:37 +0000 (15:01 -0700)]
fix copyright years

[skip ci]

21 months agoupdate README, include links to source code
Luke Kenneth Casson Leighton [Fri, 1 Jul 2022 08:03:36 +0000 (09:03 +0100)]
update README, include links to source code
mention grant numbers, and that nmigen is Trademarked.
+nmigen is a Registered Trademark of M-Labs
+https://uspto.report/TM/88980893

21 months agochange gitlab-ci to show test names
Jacob Lifshay [Fri, 1 Jul 2022 08:00:10 +0000 (01:00 -0700)]
change gitlab-ci to show test names

21 months agofix my name
Jacob Lifshay [Fri, 1 Jul 2022 07:59:05 +0000 (00:59 -0700)]
fix my name

21 months agoupdate Copyright year
Luke Kenneth Casson Leighton [Fri, 1 Jul 2022 07:38:51 +0000 (08:38 +0100)]
update Copyright year

21 months agoadd fsub support to fadd pipeline
Jacob Lifshay [Fri, 1 Jul 2022 05:07:27 +0000 (22:07 -0700)]
add fsub support to fadd pipeline

21 months agofinish adding all rounding modes to fadd -- formal proof passes
Jacob Lifshay [Fri, 1 Jul 2022 03:34:24 +0000 (20:34 -0700)]
finish adding all rounding modes to fadd -- formal proof passes

21 months agoadd rounding modes to fpbase.Overflow
Jacob Lifshay [Wed, 29 Jun 2022 04:39:22 +0000 (21:39 -0700)]
add rounding modes to fpbase.Overflow

21 months agof32 fadd formal proof is fast enough -- don't skip it anymore
Jacob Lifshay [Tue, 28 Jun 2022 05:53:06 +0000 (22:53 -0700)]
f32 fadd formal proof is fast enough -- don't skip it anymore

21 months agoadd correct NaN propagation to the fadd pipeline and formal proof
Jacob Lifshay [Tue, 28 Jun 2022 05:27:39 +0000 (22:27 -0700)]
add correct NaN propagation to the fadd pipeline and formal proof

21 months agoadd bitwuzla to gitlab-ci
Jacob Lifshay [Tue, 28 Jun 2022 05:27:28 +0000 (22:27 -0700)]
add bitwuzla to gitlab-ci

21 months agoadd formal proofs for other fadd widths, but with unittest.skip
Jacob Lifshay [Tue, 28 Jun 2022 03:44:28 +0000 (20:44 -0700)]
add formal proofs for other fadd widths, but with unittest.skip

21 months agoadd initial f16 fadd formal proof
Jacob Lifshay [Sat, 25 Jun 2022 01:04:09 +0000 (18:04 -0700)]
add initial f16 fadd formal proof

21 months agochange .gitlab-ci.yml to use nmigen with smtlib2 support
Jacob Lifshay [Fri, 24 Jun 2022 05:23:41 +0000 (22:23 -0700)]
change .gitlab-ci.yml to use nmigen with smtlib2 support

23 months agoadd set-logic ALL clause to stop cvc5 warning
Luke Kenneth Casson Leighton [Tue, 17 May 2022 08:59:29 +0000 (09:59 +0100)]
add set-logic ALL clause to stop cvc5 warning

23 months agochange run command
Jacob Lifshay [Tue, 17 May 2022 03:42:26 +0000 (20:42 -0700)]
change run command

23 months agoadd fp16mul_test.smt2
Jacob Lifshay [Tue, 17 May 2022 03:38:16 +0000 (20:38 -0700)]
add fp16mul_test.smt2

23 months agoremove redundant bvadd with 1 input
Jacob Lifshay [Fri, 13 May 2022 22:36:01 +0000 (15:36 -0700)]
remove redundant bvadd with 1 input

23 months agoadd missing inf * 0 -> NaN cases
Jacob Lifshay [Fri, 13 May 2022 22:10:17 +0000 (15:10 -0700)]
add missing inf * 0 -> NaN cases

23 months agoadd fpmul_test.smt2 as a test to see if we should bother trying to wire-up smtlib2...
Jacob Lifshay [Fri, 13 May 2022 08:23:32 +0000 (01:23 -0700)]
add fpmul_test.smt2 as a test to see if we should bother trying to wire-up smtlib2 real and fp support in yosys and nmigen

It's probably correct, z3 ran longer than I bothered to wait, it usually stops relatively quickly if there's an error in the logic.

23 months agofix ci not finding sfpy
Jacob Lifshay [Thu, 12 May 2022 03:58:48 +0000 (20:58 -0700)]
fix ci not finding sfpy

23 months agofix tests/mark as expected failure
Jacob Lifshay [Thu, 12 May 2022 03:06:31 +0000 (20:06 -0700)]
fix tests/mark as expected failure

23 months agoformat code
Jacob Lifshay [Thu, 12 May 2022 03:05:15 +0000 (20:05 -0700)]
format code

23 months agopin some dependency versions
Jacob Lifshay [Thu, 12 May 2022 01:34:17 +0000 (18:34 -0700)]
pin some dependency versions

23 months agoremove redundant arguments that are now specified in pyproject.toml
Jacob Lifshay [Wed, 11 May 2022 08:26:41 +0000 (01:26 -0700)]
remove redundant arguments that are now specified in pyproject.toml

23 months agofix some borked imports
Jacob Lifshay [Wed, 11 May 2022 08:24:04 +0000 (01:24 -0700)]
fix some borked imports

23 months agoadd pytest config -- it ignores some borked files
Jacob Lifshay [Wed, 11 May 2022 08:21:54 +0000 (01:21 -0700)]
add pytest config -- it ignores some borked files

23 months agomake sfpy build
Jacob Lifshay [Tue, 10 May 2022 04:45:43 +0000 (21:45 -0700)]
make sfpy build

23 months agofix .gitlab-ci.yml
Jacob Lifshay [Tue, 10 May 2022 04:13:17 +0000 (21:13 -0700)]
fix .gitlab-ci.yml

2 years agoswitch to using nmutil's FHDLTestCase
Jacob Lifshay [Thu, 2 Dec 2021 01:56:09 +0000 (17:56 -0800)]
switch to using nmutil's FHDLTestCase

2 years agoallow alias SimdSignal<-PartitionedSignal to allow tracking back through
Luke Kenneth Casson Leighton [Mon, 8 Nov 2021 11:25:28 +0000 (11:25 +0000)]
allow alias SimdSignal<-PartitionedSignal to allow tracking back through
git revision history

2 years agocomments
Luke Kenneth Casson Leighton [Sat, 30 Oct 2021 13:20:13 +0000 (14:20 +0100)]
comments

2 years agoallow scope to be None in SimdShape, it becomes an empty
Luke Kenneth Casson Leighton [Sat, 30 Oct 2021 13:13:44 +0000 (14:13 +0100)]
allow scope to be None in SimdShape, it becomes an empty
storage shell for parameters until a scope is given,
at which point a new SindShape is created and the PartitionPoints
can all be set up.

2 years agoadd SimdScope.__call__ function needed to copy and adapt scope
Luke Kenneth Casson Leighton [Sat, 30 Oct 2021 10:35:07 +0000 (11:35 +0100)]
add SimdScope.__call__ function needed to copy and adapt scope

2 years agoadd setmodule function to SimdScope
Luke Kenneth Casson Leighton [Sat, 30 Oct 2021 10:26:31 +0000 (11:26 +0100)]
add setmodule function to SimdScope

2 years agoput in (unused) code for SimdShape.__mul__ when both LHS and RHS
Luke Kenneth Casson Leighton [Thu, 28 Oct 2021 11:30:55 +0000 (12:30 +0100)]
put in (unused) code for SimdShape.__mul__ when both LHS and RHS
are SimdShapes.  this is unused at present, needs review

2 years agostart filling in integer SimdShape.__mul__ case with list of uses, based
Luke Kenneth Casson Leighton [Thu, 28 Oct 2021 11:15:40 +0000 (12:15 +0100)]
start filling in integer SimdShape.__mul__ case with list of uses, based
on whether the SimdShape was initially created as FIXED priority or
ELWID priority.

2 years agoadd SimdShape "priority" mode flag
Luke Kenneth Casson Leighton [Thu, 28 Oct 2021 10:41:49 +0000 (11:41 +0100)]
add SimdShape "priority" mode flag
(not used, yet)

2 years agoadd initial SimdShape.__add__
Jacob Lifshay [Thu, 28 Oct 2021 04:06:15 +0000 (21:06 -0700)]
add initial SimdShape.__add__

2 years agoadd initial SimdShape.__mul__
Jacob Lifshay [Thu, 28 Oct 2021 03:58:46 +0000 (20:58 -0700)]
add initial SimdShape.__mul__

2 years agoformat code
Jacob Lifshay [Thu, 28 Oct 2021 03:57:29 +0000 (20:57 -0700)]
format code

2 years agoremove SimdScope.get() and friends
Jacob Lifshay [Thu, 28 Oct 2021 03:41:34 +0000 (20:41 -0700)]
remove SimdScope.get() and friends

2 years agoformat code
Jacob Lifshay [Thu, 28 Oct 2021 03:36:51 +0000 (20:36 -0700)]
format code

2 years agoadd tests for SimdMap and friends
Jacob Lifshay [Wed, 27 Oct 2021 09:11:14 +0000 (02:11 -0700)]
add tests for SimdMap and friends

2 years agoadd SimdWHintMap to support tracking width_hint for XLEN
Jacob Lifshay [Wed, 27 Oct 2021 09:10:24 +0000 (02:10 -0700)]
add SimdWHintMap to support tracking width_hint for XLEN

2 years agohooray, convert PartitionedCat over to new PartType API, using
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 17:52:48 +0000 (18:52 +0100)]
hooray, convert PartitionedCat over to new PartType API, using
get_num_elements and get_el_range

2 years agoadd two new functions to PartType: get_num_elements and get_el_range
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 17:30:53 +0000 (18:30 +0100)]
add two new functions to PartType: get_num_elements and get_el_range

2 years agoremove fixed_width parameter from SimdScope.Signal
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 13:36:55 +0000 (14:36 +0100)]
remove fixed_width parameter from SimdScope.Signal
after working out how to explicitly use a SimdShape

2 years agouse explicit SimdShape for minitest example rather than
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 13:35:57 +0000 (14:35 +0100)]
use explicit SimdShape for minitest example rather than
fixed_width parameter

2 years agohad to add fixed_width parameter temporarily to confirm that the
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 13:28:55 +0000 (14:28 +0100)]
had to add fixed_width parameter temporarily to confirm that the
minitest, test_partsig_scope.py, worked (which it did).
now can work out how to remove it

2 years agodebugging of initial test_partsig_scope.py mini-test
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 13:19:02 +0000 (14:19 +0100)]
debugging of initial test_partsig_scope.py mini-test
scope and shape need to be stored in SimdSignal in order to get at them
later

2 years agoadapt/debug SimdSignal when using ElwidPartType
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 12:29:51 +0000 (13:29 +0100)]
adapt/debug SimdSignal when using ElwidPartType
example mini-test with test_partsig_scope.py working through issues

2 years agoremove unnecessary imports
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 12:29:06 +0000 (13:29 +0100)]
remove unnecessary imports

2 years agoremove unnecessary code which creates complications from SimdScope
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 12:14:06 +0000 (13:14 +0100)]
remove unnecessary code which creates complications from SimdScope
constructor.

elwid is mandatory, vec_el_counts is mandatory.  no need for complicated
types, complicated adaptation, complicated interlocking conditional
behaviour.

pass in elwid (Signal)
pass in vec_el_counts.

done.

2 years agorename the arguments to SimdShape() so as to match up with Shape() params
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 11:19:04 +0000 (12:19 +0100)]
rename the arguments to SimdShape() so as to match up with Shape() params

2 years agoadd SimdScope.Shape redirector which switches from scalar to simd behaviour
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 11:10:46 +0000 (12:10 +0100)]
add SimdScope.Shape redirector which switches from scalar to simd behaviour
depending on context.

for compatibility with nmigen Shape() the width parameter is passed
through to widths_at_elwid in SimdShape, allowing the layout() function
the opportunity to turn a scalar width into fixed element widths at
all elwids.

2 years agostart filling in ElwidPartType switch/case and other info
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 10:33:51 +0000 (11:33 +0100)]
start filling in ElwidPartType switch/case and other info
needed to get it functional and a drop-in replacement for the old
PartitionedSignal PartType behaviour

2 years agocreate a SimdShape class and begin to investigate how to tie it in
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 10:25:03 +0000 (11:25 +0100)]
create a SimdShape class and begin to investigate how to tie it in
to ElwidPartType.

2 years agoadd more code-comments
Luke Kenneth Casson Leighton [Mon, 25 Oct 2021 09:47:08 +0000 (10:47 +0100)]
add more code-comments

2 years agoreturn layout points from layout()
Luke Kenneth Casson Leighton [Sun, 24 Oct 2021 18:32:01 +0000 (19:32 +0100)]
return layout points from layout()

2 years agospelling corrections after typing on a phone
Luke Kenneth Casson Leighton [Sun, 24 Oct 2021 18:26:47 +0000 (19:26 +0100)]
spelling corrections after typing on a phone

2 years agoadd dictionary of list of layout points, start-end
Luke Kenneth Casson Leighton [Sun, 24 Oct 2021 16:14:43 +0000 (17:14 +0100)]
add dictionary of list of layout points, start-end
ElwidPartType it looks like it needs to know where each element
starts and ends, therefore provide that info at the point it was
created

2 years agoadd docstrings for additional necessary context-aware versions of
Luke Kenneth Casson Leighton [Sun, 24 Oct 2021 10:13:56 +0000 (11:13 +0100)]
add docstrings for additional necessary context-aware versions of
Signal.like and Shape in SimdScope.

2 years agofrom mobile reslly bad spelling comment why layout should remain a fn
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 16:41:20 +0000 (17:41 +0100)]
from mobile reslly bad spelling comment why layout should remain a fn

2 years agoadd back-link to why SimdScope has to get the hell out the way when
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 14:29:18 +0000 (15:29 +0100)]
add back-link to why SimdScope has to get the hell out the way when
scalar=True

2 years agoadd in code-comments
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 14:21:51 +0000 (15:21 +0100)]
add in code-comments
noticed a lot of weird code (including the hint that there might be
an intention to treat SimdSignal as a scalar ("one elwid, full width")
which is very dangerous (explained already)

added in particular some notes about the parameters that go through
to layout()

2 years agoadd comments / docstrings for layout function to illustrate where
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 14:14:13 +0000 (15:14 +0100)]
add comments / docstrings for layout function to illustrate where
the parameters actually come from

2 years agoonly set standard PartType in non-Simd-mode
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 14:03:22 +0000 (15:03 +0100)]
only set standard PartType in non-Simd-mode

2 years agoin SimdScope only update module AST Typecast function in SIMD mode
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 14:01:16 +0000 (15:01 +0100)]
in SimdScope only update module AST Typecast function in SIMD mode
do not whatever you do change the mode over to Simd casting in Scalar mode

2 years agoadd the beginnings of a usage docstring for the module and add a Signal
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 13:41:41 +0000 (14:41 +0100)]
add the beginnings of a usage docstring for the module and add a Signal
function which shows how to connect things together.

with SimdScope being passed in as the "mask" parameter, the SimdSignal
knows to switch over to "ElwidPartType mode"

2 years agoremove simd_full_width_hint, it is down to individual Signals within the
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 13:39:19 +0000 (14:39 +0100)]
remove simd_full_width_hint, it is down to individual Signals within the
context to explicitly declare their width, if in fact they need one.
some cases (as shown in the layout() function) no fixed (full) width
is required to explicitly be specified, it is determined instead from
the element widths

2 years agoadd in TODO notes tying in SimdScope/SimdMode
Luke Kenneth Casson Leighton [Fri, 22 Oct 2021 13:15:18 +0000 (14:15 +0100)]
add in TODO notes tying in SimdScope/SimdMode

2 years agoadd type annotations .pyi file for SimdScope
Jacob Lifshay [Fri, 22 Oct 2021 07:40:09 +0000 (00:40 -0700)]
add type annotations .pyi file for SimdScope

2 years agoupdate SimdScope to use vec_el_counts
Jacob Lifshay [Fri, 22 Oct 2021 07:39:42 +0000 (00:39 -0700)]
update SimdScope to use vec_el_counts

2 years agomove SimdScope to separate file
Jacob Lifshay [Fri, 22 Oct 2021 05:58:33 +0000 (22:58 -0700)]
move SimdScope to separate file

2 years agoadd LHS support into PartitionedCat. amazingly - stunningly - it works
Luke Kenneth Casson Leighton [Thu, 21 Oct 2021 15:56:51 +0000 (16:56 +0100)]
add LHS support into PartitionedCat. amazingly - stunningly - it works
https://bugs.libre-soc.org/show_bug.cgi?id=731

2 years agoconfirmed (in prototype form that LHS Cat will cause conflict
Luke Kenneth Casson Leighton [Thu, 21 Oct 2021 15:50:01 +0000 (16:50 +0100)]
confirmed (in prototype form that LHS Cat will cause conflict

2 years agocontinue truly awful hack which, in SimdSignal.__Assign__, detects the
Luke Kenneth Casson Leighton [Thu, 21 Oct 2021 14:04:33 +0000 (15:04 +0100)]
continue truly awful hack which, in SimdSignal.__Assign__, detects the
back-link to the submodule (PartitionedCat) in its return result,
and calls set_lhs_mode(True) or (False) on LHS and RHS as appropriate.

the default value is *NOT* set in the PartitionedCat constructor very very
deliberately so as to show up any bugs.  it is particularly fortunate that
this was chosen to be done because there was, in fact, a bug in the
TestCatMod unit test, which assumed that it was ok to splat a Cat() result
of a pair of SimdSignals directly onto a Signal().

it *is* in fact "technically allowed" by nmigen due to automatic casting
of UserValue, but should not strictly have been done.

2 years agoadd back-link in the return result of PartitionedCat to allow access
Luke Kenneth Casson Leighton [Thu, 21 Oct 2021 13:31:36 +0000 (14:31 +0100)]
add back-link in the return result of PartitionedCat to allow access
to the submodule.
PartitionedAssign can then detect this and alter the conditions to
LHS *before* PartitionedCat.elaborate() is called

it was already established in commit 494757caa1f that the elaborates
are all called later

2 years agoadd quick print statements to show that elaborate() gets called as a
Luke Kenneth Casson Leighton [Thu, 21 Oct 2021 12:40:29 +0000 (13:40 +0100)]
add quick print statements to show that elaborate() gets called as a
second phase after the creation of the AST tree
this gives a window of opportunity to tree-walk and set whether SimdSignals
are LHS or RHS as determined by encountering SimdSignal.__Assign__

2 years agofound an error in PartitionedAssign and PartitionedRepl
Luke Kenneth Casson Leighton [Thu, 21 Oct 2021 12:06:35 +0000 (13:06 +0100)]
found an error in PartitionedAssign and PartitionedRepl
where Slice was accidentally being done on SimdSignal rather than
SimdSignals internal sig.  whilst this was a legitimate oversight
the bug should have been found when a NotImplemented SimdSignal.__Slice__
was added.

Project Development Practices were violated here by unit tests not
having been run, which would have easily detected the bug

2 years agoremove duplicate function definition
Luke Kenneth Casson Leighton [Thu, 21 Oct 2021 11:50:58 +0000 (12:50 +0100)]
remove duplicate function definition

2 years agoremove reference to use of Swizzled class, due to it violating
Luke Kenneth Casson Leighton [Thu, 21 Oct 2021 11:49:53 +0000 (12:49 +0100)]
remove reference to use of Swizzled class, due to it violating
Project Development Practices
documented here:
https://bugs.libre-soc.org/show_bug.cgi?id=731#c10

2 years agoadd forgotten files from last commit
Jacob Lifshay [Sat, 16 Oct 2021 01:19:11 +0000 (18:19 -0700)]
add forgotten files from last commit